Added Discord as well-known OIDC provider #36781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanziske
force-pushed
the
oidc-provider-discord
branch
from
b31f72e
to
255c9c4
Compare
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
|
@romanziske Thanks for the PR, can you please add a pair of unit tests in OidcUtilsTest ? It only requires a copy and paste of tests for some other provider with minor updates, to confirm every Discord property is merged correctly and can be overridden, thanks |
This comment has been minimized.
This comment has been minimized.
|
@romanziske Thanks, can you please squash and it should be ready to go |
added unittest for merging discord oidc properties
romanziske
force-pushed
the
oidc-provider-discord
branch
from
04caa23
to
810e49e
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
sberyozkin
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Discord as a supported OIDC (OpenID Connect) provider to the Quarkus. Setting up Discord as an OIDC provider is simplified by configuring all important settings.