-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error message to quarkus-resteasy-reactive-links and improve documentation #36722
Add error message to quarkus-resteasy-reactive-links and improve documentation #36722
Conversation
836e359
to
d933f94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I added a very small comment about the error message.
...ntime/src/main/java/io/quarkus/resteasy/reactive/links/runtime/GetterAccessorsContainer.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
b225889
to
7cfd618
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some additional guidance. HTH.
...s/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java
Outdated
Show resolved
Hide resolved
...st/java/io/quarkus/resteasy/reactive/links/deployment/RestLinksWithFailureInjectionTest.java
Outdated
Show resolved
Hide resolved
13290d1
to
a16f65b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some questions after looking at the code.
...s/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
@gsmet @FroMage I'm taking another look at this and I am able to get all the fields and annotations of a class (and then search for the
but this does not include the fields and annotations a class may inherit from another one. |
@gsmet @FroMage I took another look at this today and I found the information I was missing. |
This comment has been minimized.
This comment has been minimized.
3469e69
to
588376b
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better already, because it moved the validation to build time. There are a few details remaining to fix, but we're almost there :)
...s/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java
Outdated
Show resolved
Hide resolved
...s/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java
Outdated
Show resolved
Hide resolved
588376b
to
0a2558b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review, this is getting better but there are still things to tweak.
...s/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java
Show resolved
Hide resolved
...s/deployment/src/main/java/io/quarkus/resteasy/reactive/links/deployment/LinksProcessor.java
Outdated
Show resolved
Hide resolved
|
||
// Id field not found but there's still hope | ||
classInfo = index.getClassByName(superClassName); | ||
if (superClassName != null && classInfo != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, what happens if we have a superClassName
but the superclass is not indexed? No error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, nothing would happen in that scenario. I added a check and exception for this case.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, all comments were resolved, so this is looking good :)
Review is OK, but can you rebase and remove merge commits please? Then CI will tell us. |
…sing configuration and improve documentation
1278d02
to
1f1af0c
Compare
@FroMage PR all cleaned up 🧹 |
Alright, done, thanks a lot for your patience ! |
This PR was triggered by the issue #36463
Goal is to clarify the error message the user gets when the class returned by the endpoint does not have and
id
field and also the documentation about web links