Redis: use known commands correctly #36580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate() This is more idiomatic and prevents troubles with Redis cluster where the Vert.x Redis client needs to know the key affected by the command in order to route the command to the correct cluster node. That works correctly with pre-existing `Command` instances and will _not_ work correctly with `Command.create()` until the Vert.x Redis client itself is fixed.
This comment has been minimized.
This comment has been minimized.
When the `Command.create()` method is used to create a `Command` instance for a known command (not recommended, but also not forbidden), it returns a generic instance that doesn't know anything about where the keys are in the command. Such generic instance is unusable with Redis cluster, because the target node will be selected randomly, not based on the key, and there's high chance such command will result in the `MOVED` redirect. With this commit, we normalize all results of `Command.create()` so that a pre-existing static instance for known commands is used. This is key-aware and works with Redis cluster. This commit adapts a fix submitted to Vert.x Redis client. When we upgrade to a fixed Vert.x Redis client, this commit should be reverted.
Ladicek
force-pushed
the
redis-known-commands
branch
from
2dc75be
to
04c98fd
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis: use pre-existing command instances instead of using Command.create()
This is more idiomatic and prevents troubles with Redis cluster where
the Vert.x Redis client needs to know the key affected by the command
in order to route the command to the correct cluster node. That works
correctly with pre-existing
Commandinstances and will not workcorrectly with
Command.create()until the Vert.x Redis client itselfis fixed.
Redis: normalize results of
Command.create()When the
Command.create()method is used to create aCommandinstancefor a known command (not recommended, but also not forbidden), it returns
a generic instance that doesn't know anything about where the keys are in
the command. Such generic instance is unusable with Redis cluster, because
the target node will be selected randomly, not based on the key, and there's
high chance such command will result in the
MOVEDredirect.With this commit, we normalize all results of
Command.create()so thata pre-existing static instance for known commands is used. This is key-aware
and works with Redis cluster.
This commit adapts a fix submitted to Vert.x Redis client. When we upgrade
to a fixed Vert.x Redis client, this commit should be reverted.
Fixes #28704