Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a -Dclean-cache flag #36173

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

gastaldi
Copy link
Contributor

When the build is executed with this flag, it removes the .cache which contains storage from the import and sort plugins per version (which may grow over time)

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Sep 27, 2023

Did you encounter an issue with local storage?

@geoand
Copy link
Contributor

geoand commented Sep 27, 2023

Also, shouldn't this be documented somewhere?

@gastaldi
Copy link
Contributor Author

Did you encounter an issue with local storage?

I noticed that I had at least 5 directories for the impsort maven plugin with different versions on each project.

Also, shouldn't this be documented somewhere?

Probably so, any suggestion where to put this?

@geoand
Copy link
Contributor

geoand commented Sep 27, 2023

Probably so, any suggestion where to put this

Can't think of anything obvious TBH

When the build is executed with this flag, it removes the `.cache` which contains storage from the import and sort plugins per version (which may grow over time)
@gastaldi
Copy link
Contributor Author

gastaldi commented Sep 28, 2023

@geoand I added a note in the CONTRIBUTING.md

@gastaldi gastaldi added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed area/cache labels Sep 28, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 28, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit b10a14f into quarkusio:main Sep 28, 2023
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 28, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 28, 2023
@gastaldi gastaldi deleted the clean_cache branch September 28, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants