Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge parent-first jars into single jar #36100

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 22, 2023

Relates to: #36099

@geoand
Copy link
Contributor Author

geoand commented Sep 22, 2023

@Sanne @franz1981 this is something to try and see if it brings in improvement in startup RSS.

@Sanne
Copy link
Member

Sanne commented Sep 22, 2023

I've been trying to measure the impact of this - unfortunately while it seems the patch is doing exactly what I had in mind, the benefits are much smaller than I expected: heap size on a warmed up instance of the "getting-started" quickstart goes from about 4.1 MB to 3.9 MB.

To be clear, there are some benefits... I can clearly see them in a heap dump across several areas but just not as much as I expected.
Sorry, it seems like those zip header buffers are actually not that significant as I remembered they were - something seems to have changed in the JDK.

However I'd still like it if we could proceed in this direction: having that single jar would be a step to then experiment with those other ideas.

BTW we technically have two jars now as output: there's the "quarkus-run.jar" in the root and the "lib/boot/quarkus-boot-lib.jar" - to make it possible to experiment with alternative formats perhaps these should be fused as well?

@geoand
Copy link
Contributor Author

geoand commented Sep 23, 2023

BTW we technically have two jars now as output: there's the "quarkus-run.jar" in the root and the "lib/boot/quarkus-boot-lib.jar" - to make it possible to experiment with alternative formats perhaps these should be fused as well?

Sure yeah, I can try that

All the resources from those jars
have now been moved to quarkus-run.jar
@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Sep 25, 2023
@geoand
Copy link
Contributor Author

geoand commented Sep 25, 2023

@Sanne I pushed a commit that removes the boot jar completely and just moves everything into quarkus-run.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants