Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stork observability #35934

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Stork observability #35934

merged 1 commit into from
Oct 24, 2023

Conversation

aureamunoz
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/metrics area/smallrye area/stork labels Sep 14, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2023

/cc @brunobat (micrometer), @ebullient (micrometer)

@aureamunoz aureamunoz force-pushed the stork-observability branch 2 times, most recently from 4957b27 to dd7f3c1 Compare September 22, 2023 14:39
cescoffier
cescoffier requested changes Sep 25, 2023
View reviewed changes
...r/deployment/src/main/java/io/quarkus/micrometer/deployment/binder/StorkBinderProcessor.java Show resolved Hide resolved
...ployment/src/test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsDisabledTest.java Outdated Show resolved Hide resolved
...meter/deployment/src/test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsTest.java Show resolved Hide resolved
.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java Outdated Show resolved Hide resolved
.../src/main/java/io/quarkus/micrometer/runtime/binder/stork/StorkObservationCollectorBean.java Outdated Show resolved Hide resolved
...llrye-stork/runtime/src/main/java/io/quarkus/stork/QuarkusStorkObservableInfrastructure.java Show resolved Hide resolved
@aureamunoz aureamunoz force-pushed the stork-observability branch 2 times, most recently from 8b20409 to ea04ddb Compare September 26, 2023 17:32
@aureamunoz aureamunoz marked this pull request as ready for review October 11, 2023 15:18
@quarkus-bot

This comment has been minimized.

Sign in to view
cescoffier
cescoffier requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! a few things to change, but nothing major (and enjoy your long weekend @aureamunoz )

docs/src/main/asciidoc/stork-reference.adoc Outdated Show resolved Hide resolved
.../test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsServiceDiscoveryFailTest.java Show resolved Hide resolved
...meter/deployment/src/test/java/io/quarkus/micrometer/deployment/binder/StorkMetricsTest.java Show resolved Hide resolved
@aureamunoz
Copy link
Member Author

Thanks for the review @cescoffier. I've just pushed the suggested changes. Let's see what CI says

@quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

Sign in to view
cescoffier
cescoffier approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase to see if the CI still fails on micrometer?

@gsmet
Copy link
Member

gsmet commented Oct 18, 2023

I don't think we should rebase, please have a look at the tests first locally as it seems they are failing for all JDKs which is highly suspicious.

brunobat
brunobat requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are probably missing an integration test project to make sure the produced metrics values make sense and can be maintained in the future with minimal impact.

docs/src/main/asciidoc/stork-reference.adoc Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 23, 2023

Failing Jobs - Building ebbcf7c

Status Name Step Failures Logs Raw logs Build scan
✖ JVM Tests - JDK 11 Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✖ JVM Tests - JDK 20 Build ⚠️ Check → Logs Raw logs
✔️ Maven Tests - JDK 11
✖ Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
✖ Native Tests - Messaging1 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment extensions/oidc-client-graphql/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 102 more

📦 extensions/hibernate-orm/deployment

✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project quarkus-hibernate-orm-deployment:

Please refer to /home/runner/work/quarkus/quarkus/extensions/hibernate-orm/deployment/target/surefire-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
There was an error in the forked process

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault line 58 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-graphql/deployment

📦 extensions/oidc-client-graphql/deployment

✖ io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault line 58 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx-http/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 364 more

📦 extensions/vertx-http/deployment

✖ io.quarkus.vertx.http.proxy.TrustedForwarderProxyFailureTest.testHeadersAreIgnored line 29 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

✖ io.quarkus.vertx.http.proxy.TrustedXForwarderProxiesUnknownHostnameFailureTest.testHeadersAreIgnored line 17 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testConfigFactoryInAppModuleBannedInCodeGen line 78 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testConfigFactoryInAppModuleBannedInCodeGen line 78 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

✖ io.quarkus.maven.it.JarRunnerIT.testPlatformPropertiesOverridenInApplicationProperties line 135 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.JarRunnerIT that uses io.quarkus.maven.it.verifier.MavenProcessInvocationResult was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Native Tests - Messaging1 #

- Failing: integration-tests/kafka-oauth-keycloak

📦 integration-tests/kafka-oauth-keycloak

✖ Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-kafka-oauth-keycloak: Failed to build quarkus application

@cescoffier cescoffier merged commit 7f60cf1 into quarkusio:main Oct 24, 2023
46 of 52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

@brunobat brunobat brunobat approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/metrics area/openapi area/smallrye area/stork
Projects
Quarkus Documentation
Status: Done
Milestone
3.6.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@aureamunoz @gsmet @cescoffier @brunobat