Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document init tasks #35918

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Document init tasks #35918

merged 1 commit into from
Sep 26, 2023

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Sep 13, 2023

Resolves: #35455

@iocanel
Copy link
Contributor Author

iocanel commented Sep 13, 2023

@cescoffier: Added more docs around init task. The doc covers all areas mentioned in #35455

docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/init-tasks.adoc Outdated Show resolved Hide resolved
@quarkus-bot

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Sep 22, 2023

🙈 The PR is closed and the preview is expired.

@iocanel iocanel force-pushed the wait-for-config-and-doc branch 4 times, most recently from f9ff767 to 06dc7e4 Compare September 22, 2023 11:22
@quarkus-bot

This comment has been minimized.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much much better!

@cescoffier
Copy link
Member

Squash and rebase?


[source,properties]
----
quarkus.kubernetes.init-task-defaults.wait-for-image=my/wait-for-image:1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is just how it was done or new names but feels we are being somewhat inconsistent in naming here:

quarkus.kubernetes.init-task-defaults.wait-for-image vs quarkus.kubernetes.init-containers.wait-for-flyway

should it be init-task-defaults and -init-task.wait-for-flyway or init-containers-defaults and init-containers.wait-for-flyway ?

and should wait-for-flyway be wait-for-flyway-image ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @maxandersen, it looks more consistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and should wait-for-flyway be wait-for-flyway-image ?

In quarkus.kubernetes.init-container.wait-for-flyway.image the wait-for-flyway part is the container name. This is part of the container customization options that we have since forever.

The quarkus.kubernetes.init-task-defaults is a new object I added to hold a couple of flags and a default image.

I could possibly change the way we pass the image to be more aligned with how we configure containers and make it something like quarkus.kubernetes.init-task-defaults.wait-for-container.image. Would that work better @maxandersen @cescoffier ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 26, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@iocanel iocanel merged commit dcb875a into quarkusio:main Sep 26, 2023
24 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Simplify and Document how to customize the "wait-for" image when using init tasks on kubernetes
3 participants