-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document init tasks #35918
Document init tasks #35918
Conversation
@cescoffier: Added more docs around init task. The doc covers all areas mentioned in #35455 |
055a22d
to
6196eee
Compare
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
f9ff767
to
06dc7e4
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much much better!
Squash and rebase? |
|
||
[source,properties] | ||
---- | ||
quarkus.kubernetes.init-task-defaults.wait-for-image=my/wait-for-image:1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is just how it was done or new names but feels we are being somewhat inconsistent in naming here:
quarkus.kubernetes.init-task-defaults.wait-for-image
vs quarkus.kubernetes.init-containers.wait-for-flyway
should it be init-task-defaults
and -init-task.wait-for-flyway
or init-containers-defaults
and init-containers.wait-for-flyway
?
and should wait-for-flyway
be wait-for-flyway-image
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @maxandersen, it looks more consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and should
wait-for-flyway
bewait-for-flyway-image
?
In quarkus.kubernetes.init-container.wait-for-flyway.image
the wait-for-flyway
part is the container name. This is part of the container customization options that we have since forever.
The quarkus.kubernetes.init-task-defaults
is a new object I added to hold a couple of flags and a default image.
I could possibly change the way we pass the image to be more aligned with how we configure containers and make it something like quarkus.kubernetes.init-task-defaults.wait-for-container.image
. Would that work better @maxandersen @cescoffier ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
06dc7e4
to
aeab567
Compare
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Resolves: #35455