Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default response content type using GraphQL spec #35769

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Default response content type using GraphQL spec #35769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bff1fb7
Default response content type using GraphQL spec
ivanp Sep 6, 2023
5550b70
Accept requests that ask for application/graphql-response+json
jmartisk Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...me/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLExecutionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class SmallRyeGraphQLExecutionHandler extends SmallRyeGraphQLAbstractHand
private static final String EXTENSIONS = "extensions";
private static final String APPLICATION_GRAPHQL = "application/graphql";
private static final String OK = "OK";
private static final String DEFAULT_RESPONSE_CONTENT_TYPE = "application/graphql+json; charset="
private static final String DEFAULT_RESPONSE_CONTENT_TYPE = "application/graphql-response+json; charset="
+ StandardCharsets.UTF_8.name();
private static final String DEFAULT_REQUEST_CONTENT_TYPE = "application/json; charset="
+ StandardCharsets.UTF_8.name();
Expand Down Expand Up @@ -295,8 +295,9 @@ private static String getCharset(String mimeType) {
}

private boolean isValidAcceptRequest(String mimeType) {
// At this point we only accept two
return mimeType.startsWith("application/json")
|| mimeType.startsWith("application/graphql-response+json")
// application/graphql+json is incorrect, but we keep it for backwards compatibility
|| mimeType.startsWith("application/graphql+json");
}

Expand Down
Loading