Request reauthentication by default if OIDC state state query param is missing #35755
+58
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
approved these changes
Sep 5, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
|
Thanks @gastaldi, just checked today with this PR, the experience is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35754
Instead of getting the users puzzled with 401, let them re-authenticate again if the previous authentication attempt did not complete with the redirect to Quarkusand thus leaving some state cookie in the browser cache - failing with 401 when the user retries to access Quarkus is only causing confusion with the users likely finding
fail-on-missing-state-paramand disabling it.Tests have been added/fixed to check that when this parameter is disabled, default now, then
302is returned, with the re-authentication redirect.401is enabled only if this property is enforced