Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Datasource timing issues with Liquibase / Flyway and OpenTelemetry #35315

Merged
merged 5 commits into from
Aug 11, 2023

Commits on Aug 10, 2023

  1. Deprecate DataSources#fromName

    geoand committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    e6cad15 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2117996 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    70b7552 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Rework Flyway CDI initialization

    In passing, made the Flyway beans singleton as we access them a lot more
    via CDI and we would have created a lot more beans.
    Given the comment I removed where the Dependent scope was added, I think
    we can consider it is a good move.
    I'm aware this means, we will keep Flyway beans around but that's the
    price we have to pay to not slow down the initialization too much.
    gsmet committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    66e525c View commit details
    Browse the repository at this point in the history
  2. Make sure the default datasource FlywayContainer is returned first

    Ideally we wouldn't rely on this but given we had a test relying on it,
    better keep this behavior given it doesn't cost much.
    gsmet committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ec04931 View commit details
    Browse the repository at this point in the history