Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev UI Arc Dependency graph diagram #34955

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jul 24, 2023

This PR add the Arc Graph Dependency back in the new Dev UI. It now use an echarts graph that is wrapped in a component.

arc_dependecy_graph

@jmartisk @xstefank - I think you are waiting for this ? pinging you as promised.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/vertx labels Jul 24, 2023
@phillip-kruger phillip-kruger changed the title Dev UI graph diagram Dev UI Arc Dependency graph diagram Jul 24, 2023
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 24, 2023
Copy link
Contributor

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 25, 2023

Failing Jobs - Building 69e05b7

Status Name Step Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testResourcesFromClasspath line 1234 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.DevMojoIT was not fulfilled within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.DevMojoIT.testResourcesFromClasspath line 1234 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.DevMojoIT was not fulfilled within 20 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@cescoffier cescoffier merged commit 80fbc71 into quarkusio:main Jul 25, 2023
46 of 47 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 25, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 25, 2023
@mkouba
Copy link
Contributor

mkouba commented Jul 31, 2023

@phillip-kruger It looks really good.

The only things I'm missing are:

  1. Drag the component and drop at fixed position - this is useful for more complex dependency graphs
  2. Max dependency level - again, useful for more complex dependency graphs
  3. Zoom in/out does not seem to work well, at least in Firefox 115

@phillip-kruger
Copy link
Member Author

Thanks @mkouba . Yeah we can fine tune to add those features.

@phillip-kruger phillip-kruger deleted the dev-ui-graph-diagram branch August 11, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants