Add more CORS regex tests and fix the CORS regex example #34829
Merged
+27
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34718.
This PR adds few more tests using the regex documented in the docs.
Note, the same regex requires different treatment when using it directly from Java (
\\.
to represent a dot char) but\\\\.
if the same regex is supplied from the properties.I've proposed some text suggesting why it is the case, please tune it as required.
CC @gsmet @dmlloyd @radcortez and everyone else is welcome to comment :-)