Add support for virtual threads in smallrye-reactive-messaging #34557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
requested changes
Jul 6, 2023
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Show resolved
Hide resolved
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
jponge
changed the title
gsmet
reviewed
Jul 6, 2023
core/deployment/src/main/java/io/quarkus/deployment/console/AeshConsole.java
Outdated
Show resolved
Hide resolved
franz1981
reviewed
Jul 6, 2023
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
|
Upstream changes in discussion related to this one : smallrye/smallrye-reactive-messaging#2219 |
anavarr
force-pushed
the
smallrye-reactive-messaging
branch
from
3a53c7c
to
99d9827
Compare
|
@anavarr we've released changes to Reactive Messaging in 4.8.0 to control the concurrency better. I'll bump the RM dependency in a separate PR and push updates to this one. |
|
@ozangunalp I let you drive this one home. |
cescoffier
requested changes
Jul 17, 2023
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
…hreads. Replacing the queue implementation with a lock-free variant resolves the issue
ozangunalp
force-pushed
the
smallrye-reactive-messaging
branch
from
99d9827
to
de2052d
Compare
|
@anavarr as we discussed I pushed changes to this after #34716. |
cescoffier
approved these changes
Jul 17, 2023
...ava/io/quarkus/smallrye/reactivemessaging/deployment/SmallRyeReactiveMessagingProcessor.java
Outdated
Show resolved
Hide resolved
franz1981
reviewed
Jul 17, 2023
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
franz1981
reviewed
Jul 17, 2023
...e/src/main/java/io/quarkus/smallrye/reactivemessaging/runtime/QuarkusWorkerPoolRegistry.java
Outdated
Show resolved
Hide resolved
jponge
reviewed
Jul 17, 2023
ozangunalp
force-pushed
the
smallrye-reactive-messaging
branch
from
de2052d
to
1b7d001
Compare
|
🙈 The PR is closed and the preview is expired. |
ozangunalp
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged work from @ozangunalp and @cescoffier to add support for virtual threads in smallrye-reactive-messaging.
When using devmode, using
LinkedBlockingDequefor the Aesh console caused deadlocks when using System.out in handlers annotated with@RunOnVirtualThread. TheLinkedBlockingDequewas replaced with aConcurrentLinkedQueueand the deadlock disappeared.The ReentrantLock used in
LinkedBlockingDequeseems to be responsible for the deadlock