-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove long deprecated options from CertificateConfig #34540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let's try to get #33228 in before doing that.
I'll rebase and try to get it merged soon.
Sure, no problem |
This comment has been minimized.
This comment has been minimized.
These options where deprecated more than 2 years ago in 272119d
4f48afc
to
d55e533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased this PR and fixed the gRPC tests.
💪 |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
These options where deprecated more than 2 years ago in 272119d