Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Analytics - prompt improvements #34482

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Build Analytics - prompt improvements #34482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
863338a
Build Analytics - prompt improvements
brunobat Jul 3, 2023
3b65753
Build Analytics - clarify prompt message
brunobat Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ent-projects/tools/analytics-common/src/main/java/io/quarkus/analytics/ConfigService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class ConfigService {
+ "--- Help improve Quarkus ---" + NEW_LINE
+ "----------------------------" + NEW_LINE
+ "* Learn more: https://quarkus.io/usage/" + NEW_LINE
+ "* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n) " + NEW_LINE;
+ "* Do you agree to contribute anonymous build time data to the Quarkus community? (y/n and enter) " + NEW_LINE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: make the default option uppercased?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had that before and was changed to lowercase.

private static final int DEFAULT_REFRESH_HOURS = 12;

private AnalyticsRemoteConfig config;
Expand Down
Loading