Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripting guide #32028

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Update scripting guide #32028

merged 1 commit into from
Oct 5, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Mar 22, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 22, 2023

🙈 The PR is closed and the preview is expired.

docs/src/main/asciidoc/scripting.adoc Outdated Show resolved Hide resolved
@zakkak zakkak requested a review from gsmet April 26, 2023 08:42
@@ -149,9 +147,11 @@ For now the application does nothing new.
.How do I edit this file and get content assist?
====
As there is nothing but a `.java` file, most IDE's don't handle content assist well.
To work around that you can run `jbang edit quarkusapp.java`, this will print out a directory that will have a temporary project setup you can use in your IDE.
To work around that you can run `jbang edit quarkusapp.java`.
This will create a directory, containing a temporary project setup, and will open it in https://www.jbang.dev/documentation/guide/latest/editing.html[the default editor].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in latest jbang we actually default to assume you have jbang plugin installed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the text to only say use "jbang edit quarkusapp.java` or refer to the jbang docs for more information.

2020-08-30 06:23:36,846 INFO [io.quarkus] (main) Quarkus {quarkus-version} native started in 0.015s. Listening on: http://0.0.0.0:8080
2020-08-30 06:23:36,846 INFO [io.quarkus] (main) Profile prod activated.
2020-08-30 06:23:36,846 INFO [io.quarkus] (main) Installed features: [cdi, resteasy-reactive]
2023-03-22 09:38:45,450 INFO [io.quarkus] (main) quarkus 999-SNAPSHOT native (powered by {quarkus-version}) started in 0.009s. Listening on: http://0.0.0.0:8080
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2023-03-22 09:38:45,450 INFO [io.quarkus] (main) quarkus 999-SNAPSHOT native (powered by {quarkus-version}) started in 0.009s. Listening on: http://0.0.0.0:8080
2023-03-22 09:38:45,450 INFO [io.quarkus] (main) quarkus {quarkus-version} native (powered by {quarkus-version}) started in 0.009s. Listening on: http://0.0.0.0:8080

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the application version, not the quarkus version.

i.e., running the example above with 3.2.0.Final results in the following output:

2023-07-10 14:49:08,347 INFO  [io.quarkus] (main) quarkus 999-SNAPSHOT on JVM (powered by Quarkus 3.2.0.Final) started in 0.289s. Listening on: http://0.0.0.0:8080

Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry - completely missed this. fixes are good but a few adjustment nee

@zakkak
Copy link
Contributor Author

zakkak commented Aug 17, 2023

sorry - completely missed this. fixes are good but a few adjustment nee

@maxandersen could you please have another look?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the comments were addressed.

@gsmet gsmet dismissed maxandersen’s stale review October 5, 2023 16:07

Comments were addressed by Foivos

@gsmet gsmet merged commit a75109d into quarkusio:main Oct 5, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Oct 5, 2023
@zakkak zakkak deleted the 2023-03-22-doc-fix branch October 6, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants