-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete elasticsearch-high-level-rest-client extension and upgrade dev-services and tests to Elasticsearch 8 #31997
Conversation
/cc @gsmet (elasticsearch,hibernate-search), @loicmathieu (elasticsearch) |
🙈 The PR is closed and the preview is expired. |
547bb7b
to
a5493a4
Compare
We've upgraded to Hibernate Search 6.2, so we can upgrade to ES 8.8 safely now (there won't be any warnings in the logs about HSearch not supporting ES 8) |
Alright, the (deprecated) Elasticsearch high-level client doesn't work with Elasticsearch 8. I'll remove it, because it's been deprecated since Quarkus 3.0 IIRC. |
Fine by me but let's do it in a separate PR as we need to mark it as noteworthy. |
OK, well, I see the title is clear enough, I will make this PR noteworthy. |
Added "delete elasticsearch-high-level-rest-client extension" to the scope of this PR.
Having a look at the test failures. |
|
f2998bc
to
0505e93
Compare
I wasn't able to reproduce locally, so I added a bit more configuration to get rid of environment-specific problems (such as a disk too full leading to Elasticsearch misbehaving). Let's see how it goes. |
This comment has been minimized.
This comment has been minimized.
I think the failing Maven tests on Windows are just flaky. |
0505e93
to
d46003f
Compare
This comment has been minimized.
This comment has been minimized.
Because we've deprecated it a while ago (in Quarkus 3.0) and it no longer works with Elasticsearch 8.
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
… expects and object but GELF uses a string
…ev services and tests In a single-node setup they just don't make sense, and lead to problems on large disks with little space left. See https://www.elastic.co/guide/en/elasticsearch/reference/8.8/modules-cluster.html#disk-based-shard-allocation
d46003f
to
c4aa937
Compare
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building c4aa937
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/hibernate-orm/deployment integration-tests/elasticsearch-java-client
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 92 more 📦 extensions/hibernate-orm/deployment✖
📦 integration-tests/elasticsearch-java-client✖ ⚙️ JVM Tests - JDK 17 Windows #- Failing: independent-projects/tools/analytics-common
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/maven and 214 more 📦 independent-projects/tools/analytics-common✖
✖
✖
|
Merging as the build failures seem unrelated and already present on Seems like even before my changes, we're reaching the 6h timeout on some jobs... We'll have to work on that. |
I updated the migration guide to mention these changes: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.3#elasticsearch |
The extension has been removed from Quarkus in quarkusio/quarkus#31997.
Fixes #29523
Fixes #31960
Co-authored by @phillip-kruger
Creating as draft since we need an upgrade to Hibernate Search 6.2 (not yet released) in order to get official compatibility with ES 8.