Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete elasticsearch-high-level-rest-client extension and upgrade dev-services and tests to Elasticsearch 8 #31997

Merged
merged 6 commits into from
Aug 7, 2023

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Mar 21, 2023

Fixes #29523
Fixes #31960

Co-authored by @phillip-kruger

Creating as draft since we need an upgrade to Hibernate Search 6.2 (not yet released) in order to get official compatibility with ES 8.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 21, 2023

/cc @gsmet (elasticsearch,hibernate-search), @loicmathieu (elasticsearch)

gsmet
gsmet previously approved these changes Mar 21, 2023
@github-actions
Copy link

github-actions bot commented Mar 21, 2023

🙈 The PR is closed and the preview is expired.

@gsmet gsmet added the triage/on-ice Frozen until external concerns are resolved label Mar 21, 2023
@yrodiere yrodiere marked this pull request as ready for review July 7, 2023 11:22
@yrodiere yrodiere added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed triage/on-ice Frozen until external concerns are resolved labels Jul 7, 2023
@yrodiere
Copy link
Member Author

yrodiere commented Jul 7, 2023

We've upgraded to Hibernate Search 6.2, so we can upgrade to ES 8.8 safely now (there won't be any warnings in the logs about HSearch not supporting ES 8)

@yrodiere
Copy link
Member Author

yrodiere commented Jul 7, 2023

Alright, the (deprecated) Elasticsearch high-level client doesn't work with Elasticsearch 8. I'll remove it, because it's been deprecated since Quarkus 3.0 IIRC.

@yrodiere yrodiere removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 7, 2023
@yrodiere yrodiere changed the title Upgrade dev-services and tests to Elasticsearch 8 Delete elasticsearch-high-level-rest-client extension and upgrade dev-services and tests to Elasticsearch 8 Jul 7, 2023
@gsmet
Copy link
Member

gsmet commented Jul 7, 2023

Alright, the (deprecated) Elasticsearch high-level client doesn't work with Elasticsearch 8. I'll remove it, because it's been deprecated since Quarkus 3.0 IIRC.

Fine by me but let's do it in a separate PR as we need to mark it as noteworthy.

@gsmet
Copy link
Member

gsmet commented Jul 7, 2023

OK, well, I see the title is clear enough, I will make this PR noteworthy.

@yrodiere yrodiere requested a review from gsmet July 7, 2023 16:15
@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 7, 2023
@yrodiere yrodiere dismissed gsmet’s stale review July 7, 2023 16:16

Added "delete elasticsearch-high-level-rest-client extension" to the scope of this PR.

@yrodiere
Copy link
Member Author

Having a look at the test failures.

@gsmet
Copy link
Member

gsmet commented Jul 31, 2023

integration-tests/grpc-hibernate was a flaky test

@yrodiere
Copy link
Member Author

yrodiere commented Aug 2, 2023

Having a look at the test failures.

I wasn't able to reproduce locally, so I added a bit more configuration to get rid of environment-specific problems (such as a disk too full leading to Elasticsearch misbehaving). Let's see how it goes.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 2, 2023
@quarkus-bot

This comment has been minimized.

@yrodiere
Copy link
Member Author

yrodiere commented Aug 3, 2023

I think the failing Maven tests on Windows are just flaky.

@quarkus-bot

This comment has been minimized.

yrodiere and others added 6 commits August 4, 2023 17:55
Because we've deprecated it a while ago (in Quarkus 3.0) and it no
longer works with Elasticsearch 8.
Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
…ev services and tests

In a single-node setup they just don't make sense,
and lead to problems on large disks with little space left.
See https://www.elastic.co/guide/en/elasticsearch/reference/8.8/modules-cluster.html#disk-based-shard-allocation
@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 5, 2023

Failing Jobs - Building c4aa937

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 20
Native Tests - Misc2 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment integration-tests/elasticsearch-java-client 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 92 more

📦 extensions/hibernate-orm/deployment

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test (default-test) on project quarkus-hibernate-orm-deployment: There are test failures.

Please refer to /home/runner/work/quarkus/quarkus/extensions/hibernate-orm/deployment/target/surefire-reports for the individual test results.
Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.

📦 integration-tests/elasticsearch-java-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.43.0:start (docker-start) on project quarkus-integration-test-elasticsearch-java-client: I/O Error


⚙️ JVM Tests - JDK 17 Windows #

- Failing: independent-projects/tools/analytics-common 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/maven and 214 more

📦 independent-projects/tools/analytics-common

io.quarkus.analytics.AnalyticsServiceTest.sendAnalyticsTest line 160 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.analytics.AnalyticsServiceTest Expected at least one request matching: {
  "url" : "/v1/track",

io.quarkus.analytics.rest.RestClientFailTest.postIdentityServerTTLExceeded line 87 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a io.quarkus.analytics.rest.RestClientFailTest Expected at least one request matching: {
  "url" : "/v1/identify",

io.quarkus.analytics.rest.RestClientTest.postIdentity line 102 - More details - Source on GitHub

java.util.concurrent.TimeoutException
	at java.base/java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1960)
	at java.base/java.util.concurrent.CompletableFuture.get(CompletableFuture.java:2095)

@yrodiere
Copy link
Member Author

yrodiere commented Aug 7, 2023

Merging as the build failures seem unrelated and already present on main: https://github.com/quarkusio/quarkus/actions/runs/5771471073

Seems like even before my changes, we're reaching the 6h timeout on some jobs... We'll have to work on that.

@yrodiere yrodiere merged commit 33482f5 into quarkusio:main Aug 7, 2023
48 of 51 checks passed
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Aug 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 7, 2023
@yrodiere
Copy link
Member Author

yrodiere commented Aug 7, 2023

I updated the migration guide to mention these changes: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.3#elasticsearch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/elasticsearch area/hibernate-search Hibernate Search area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/logging area/platform Issues related to definition and interaction with Quarkus Platform kind/bugfix release/noteworthy-feature triage/flaky-test
Projects
None yet
5 participants