Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hibernate ORM 5.6.15.Final #30946

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Feb 7, 2023

Fixes #30234

Release notes for ORM 5.6.15.Final: https://in.relation.to/2023/02/06/hibernate-orm-5615-final/

Note this patch should apply cleanly to 2.16, at least for the Java part, as it does not rely on JPA classes directly.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Feb 7, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm)

@quarkus-bot

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Feb 7, 2023

Don't merge this yet. Something went wrong with the CI.

@gsmet
Copy link
Member

gsmet commented Feb 7, 2023

@famod I think something went wrong with GIB here. And the only culprit I could see would be the set-output change as AFAICS GIB lists the modules properly.

@yrodiere
Copy link
Member Author

yrodiere commented Feb 7, 2023

@gsmet It just occurred to me the tests won't work on 2.13/2.16 because they rely on a feature introduced after 2.16.0: #30640

I can either submit a different PR to 2.16 that relies on quarkus.hibernate-orm.unsupported-properties instead, or do the change directly in this PR. Any preference?

@gsmet
Copy link
Member

gsmet commented Feb 7, 2023

Or we also backport #30640 to 2.16?

(That won't solve the 2.13 issue though)

@gsmet
Copy link
Member

gsmet commented Feb 7, 2023

Given we want this in 2.13, maybe a PR targeting 2.16 that I could apply to 2.13 too would be better.

@yrodiere
Copy link
Member Author

yrodiere commented Feb 7, 2023

Given we want this in 2.13, maybe a PR targeting 2.16 that I could apply to 2.13 too would be better.

Done: #30956

The labels on that PR might not be what you need; sorry about that, I'm not sure what to do when actually backporting since you always do it for me :)

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2023

Failing Jobs - Building b189ead

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/mongodb-rest-data-panache 

📦 integration-tests/mongodb-rest-data-panache

io.quarkus.it.mongodb.rest.data.panache.MongoDbRestDataPanacheTest.shouldNotCreateOrDeleteAuthor - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

@gsmet gsmet merged commit 33bddf0 into quarkusio:main Feb 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 7, 2023
@famod
Copy link
Member

famod commented Feb 7, 2023

@famod I think something went wrong with GIB here. And the only culprit I could see would be the set-output change as AFAICS GIB lists the modules properly.

@gsmet do you have a link to a worflow run that failed? I can't seem to find one here...

@gsmet
Copy link
Member

gsmet commented Feb 8, 2023

@famod it didn't fail per se but it didn't run the JVM tests nor the native tests: https://github.com/quarkusio/quarkus/actions/runs/4113233527

So something is off.

@famod
Copy link
Member

famod commented Feb 8, 2023

@gsmet
Copy link
Member

gsmet commented Feb 8, 2023

We are doing something related to that here: https://github.com/quarkusio/quarkus/pull/30867/files#diff-d8e36253822cffbdf21e333bcba467345b46e6095927dda98399fe7f21f4679aL168-R168

But I don't understand why it would change (except if GitHub is doing some magic).

@famod
Copy link
Member

famod commented Feb 8, 2023

Ah, I vaguely remember that one. Since we don't convert %0A back to linefeed, I think the problem makes sense.
::set-output was probably not "symmetric" in that sense.

@gsmet
Copy link
Member

gsmet commented Feb 8, 2023

So do you think we could just push the line feeds to the file without replacing them at all?

Or do we need to change them back when we read the output?

@famod
Copy link
Member

famod commented Feb 8, 2023

I'll try to find some time this evening to test this in a sample repo.

@famod
Copy link
Member

famod commented Feb 8, 2023

@gsmet #31019 contains the fix

@yrodiere yrodiere deleted the orm5_6_15 branch August 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/bugfix kind/component-upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate dirty property false positives
3 participants