Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix automatic module name of the change agent #30944

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Fix automatic module name of the change agent #30944

merged 2 commits into from
Feb 7, 2023

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Feb 7, 2023

Fixes #30868.

CC @gsmet @geoand

@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven labels Feb 7, 2023
geoand
geoand approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor

geoand commented Feb 7, 2023

Please rebase onto main so we can get rid of the merge commit

gsmet
gsmet approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 67c66d3 into quarkusio:main Feb 7, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 7, 2023
@triceo triceo deleted the klass branch February 7, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven
Projects
None yet
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.

Potentially revert quarkus-class-change-agent artifact name change
3 participants
@triceo @geoand @gsmet