ArC - reduce allocations for intercepted methods #30816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
reviewed
Feb 2, 2023
...nt-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/AroundInvokeInvocationContext.java
Show resolved
Hide resolved
mkouba
force-pushed
the
arc-ic-reduce-allocations
branch
from
dcfb0a5
to
d36c7db
Compare
This comment has been minimized.
This comment has been minimized.
|
It seems that failures are related. Investigating... |
mkouba
force-pushed
the
arc-ic-reduce-allocations
branch
from
d0aa755
to
0f47d18
Compare
|
Looks good - second and third commit are basically alignment with what Weld does as well (verified it there) but let's see what the CI has to say :) |
Thanks for verification! |
This comment has been minimized.
This comment has been minimized.
gsmet
added
the
triage/needs-rebase
- forwarding lambdas are stateless and thus may become part of immutable InterceptedMethodMetadata - note that metadata are shared accross all invocations of an intercepted method
- that are not observers/producers
mkouba
force-pushed
the
arc-ic-reduce-allocations
branch
from
fc9c95a
to
0d3d692
Compare
mkouba
removed
the
triage/needs-rebase
Ladicek
approved these changes
Feb 6, 2023
manovotn
approved these changes
Feb 6, 2023
mkouba
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterceptorBenchmark shows ~ 14% lower allocation rate (using JMH GC profiler) and ~ 4% better throughput.