Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove okhttp leftovers #30798

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Remove okhttp leftovers #30798

merged 1 commit into from
Feb 2, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Feb 2, 2023 •
edited
Loading

With #30480 in, we no longer need any of the okhttp stuff

@geoand
Copy link
Contributor Author

geoand commented Feb 2, 2023

cc @manusa

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/kubernetes labels Feb 2, 2023
@geoand geoand requested a review from gastaldi February 2, 2023 07:22
@manusa
Copy link
Contributor

manusa commented Feb 2, 2023

Remember OkHttp is still used (server-side) in the MockServer.
That's why I added the kubernetes-httpclient-okhttp to the enforcer rules instead of just okhttp.
Removing OkHttp from the MockServer will still need some time.

@geoand
Copy link
Contributor Author

geoand commented Feb 2, 2023

Do we still need it in the BOM though?

@quarkus-bot

This comment has been minimized.

Sign in to view
@manusa
Copy link
Contributor

manusa commented Feb 2, 2023

Do we still need it in the BOM though?

That I don't know (I'm unsure why it was added to the BOM in first place)
Sincere the Mock Server is just used for testing, and OkHttp 4 should be binary compatible with v3 loading a different version probably won't have any undesired repercussion.

@geoand
Copy link
Contributor Author

geoand commented Feb 2, 2023

It was added to the BOM for the k8s client.

@geoand
Copy link
Contributor Author

geoand commented Feb 2, 2023

I'll just remove tthe commit that changed the BOM for now, as it needs more work

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 2, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit fcb7e7b into quarkusio:main Feb 2, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Feb 2, 2023
@gsmet
Copy link
Member

gsmet commented Feb 2, 2023

@geoand hmmm, do we have okhttp coming from quarkus-test-infinispan-client? That would be a very unpleasant surprise.

@geoand
Copy link
Contributor Author

geoand commented Feb 2, 2023

I agree... I don't have the time to look into it now which is why I removed the connit

@geoand geoand deleted the okhttp-leftovers branch February 2, 2023 09:51
@jtama jtama mentioned this pull request May 2, 2023
Closed
@lasteris lasteris mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@gastaldi gastaldi Awaiting requested review from gastaldi

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/kubernetes
Projects
None yet
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @manusa @gsmet