Use quotes for the path to find maven basedir in mvnw #30750
Conversation
quarkus-bot
bot
added
area/devtools
|
Thanks, will check and update the upstream project. 👍🏽 |
| @@ -164,7 +164,7 @@ concat_lines() { | |||
| fi | |||
| } | |||
|
|
|||
| BASE_DIR=$(find_maven_basedir "$(dirname $0)") | |||
| BASE_DIR=$(find_maven_basedir "$(pwd)") | |||
There was a problem hiding this comment.
| BASE_DIR=$(find_maven_basedir "$(pwd)") | |
| BASE_DIR=$(find_maven_basedir "$(dirname "$0")") |
There was a problem hiding this comment.
I think I tried that but it didn't work for the s p a c e s case.
Will double check
There was a problem hiding this comment.
Please double check, I tested it and it works for me.
FTR: This is already fixed upstream and is using the same approach (I even tested the script from the master branch of maven-wrapper and it works).
There was a problem hiding this comment.
PR updated, works fine now. I probably combined that change with other experiments.
rsvoboda
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failing Jobs - Building 00f0fb6
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
Use quotes for the path to find maven basedir in mvnw
Fixes #30642
Sync with the latest wrapper upstream changes https://github.com/apache/maven-wrapper/blob/master/maven-wrapper-distribution/src/resources/mvnw#L173
CC @jorsol
Old info (see comments for the details):
pwdwas used before #30108 changesapache/maven-wrapper@e87947e changed the line in upstream, imho cosmetic and MWRAPPER-56 unrelated change that caused regression in behavior on Quarkus CLI side