Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for testing knative environment #30743

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 31, 2023

This can now be done because
fabric8io/kubernetes-client#4447 is included in version 6.3 of the k8s client

This can now be done because
fabric8io/kubernetes-client#4447
is included in version 6.3 of the k8s client
@geoand
Copy link
Contributor Author

geoand commented Jan 31, 2023

cc @manusa

@manusa
Copy link
Contributor

manusa commented Jan 31, 2023

👍 I'll rebase #30480 once you merge this since I might include changes that affect this class and the KubernetesBuildItem in general.

@geoand
Copy link
Contributor Author

geoand commented Jan 31, 2023

Cool

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 31, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 9281ebe into quarkusio:main Jan 31, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 31, 2023
@geoand geoand deleted the knative-fix branch February 1, 2023 09:39
@manusa
Copy link
Contributor

manusa commented Feb 20, 2023

Note that this method will need refactoring when bumping the client to 6.5 or at most 6.6

fabric8io/kubernetes-client#4869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants