Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest Client: Add property to skip hostname verification #27956

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Rest Client: Add property to skip hostname verification #27956

merged 1 commit into from
Dec 5, 2022

Commits on Dec 5, 2022

  1. Rest Client: Add property to skip hostname verification 

    Before these changes, we only can disable the hostname verification in Rest Client classic by providing the following property:

```
quarkus.rest-client.extensions-api.hostname-verifier=io.quarkus.restclient.NoopHostnameVerifier
```

However, this is not working in Rest Client reactive because setting a hostname verifier strategy is not supported by the Vert-x HTTP Client. 

With these changes, we have added a new property in both Rest Client classic and reactive `quarkus.rest-client.extensions-api.verify-host=true or false`. In Rest Client classic, when disabling the verify host, internally it will add the `NoopHostnameVerifier` strategy. In Rest Client reactive, it will properly configure the Vert.x HTTP client to disable the hostname verification. Therefore, in both Rest Client implementations (classic and reactive), the behaviour is the same. 

Fix quarkusio#27901
    @Sgitario @geoand
    Sgitario authored and geoand committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    941d3a6 View commit details
    Browse the repository at this point in the history