Allow HttpServerOptionsCustomizer to set KeyManager and TrustManager for HTTPS server #27682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows application to set its own KeyManager and TrustManager to Vert.x by delaying the check to disable TLS (in absense of certificate&key) to be done after the call to HttpServerOptionsCustomizer, instead of before.
This comment has been minimized.
This comment has been minimized.
cescoffier
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the application to use the
HttpServerOptionsCustomizermechanism to set their ownKeyManagerandTrustManagerto Vert.x. That is achieved by simply moving the check to disable TLS (in absense of server certificate & key) from before the customizer call to after the call.Without this change the
HttpServerOptionsCustomizer.customizeHttpsServer()method is not called unless certificate and key were already defined inquarkus.http.ssl.certificate.*config options. Setting the config option is not desirable when the application wants to customize the HTTPS server by setting its ownKeyManager. In that casequarkus.http.ssl.certificate.*options are not applicable, since Quarkus is not in control of setting the server credentials.Example use case that is enabled by this PR: Application sets custom
KeyManagerthat supports certificate hot-reload without restarting the server (xref #15926).Fixes #27481