Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle JDBC drivers should not be initialized at runtime #23178

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Jan 25, 2022

Fixes #23113

Tested locally; this would need a module with both JDBC drivers from Oracle and DB2 - not sure what we want to do there, so let's discuss it separately and try to have the fix in 2.7 (as I'm unlikely to be able to contribute the integration test by then).

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 25, 2022
@gsmet gsmet merged commit e3c2922 into quarkusio:main Jan 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 25, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 25, 2022
@bvahdat
Copy link

bvahdat commented Jan 25, 2022

Fixes #23113

Tested locally; this would need a module with both JDBC drivers from Oracle and DB2 - not sure what we want to do there, so let's discuss it separately and try to have the fix in 2.7 (as I'm unlikely to be able to contribute the integration test by then).

Thanks a lot @Sanne / @gsmet

I could not find this fix on the 2.7 branch. Maybe you will backport it later?

@Sanne Sanne deleted the OracleInit branch January 25, 2022 15:02
@Sanne
Copy link
Member Author

Sanne commented Jan 25, 2022

@bvahdat yes, gsmet has a script that alignes the branches in batches. The label "backport" marks it for the script to take it later.

If you want to try it out, feel free to cherry-pick it.. should be trivial.

@Sanne
Copy link
Member Author

Sanne commented Jan 25, 2022

(or wait a day.. :) )

@bvahdat
Copy link

bvahdat commented Jan 25, 2022

Awesome, I prefer to wait then 👍

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.0.Final Jan 25, 2022
@bvahdat
Copy link

bvahdat commented Jan 26, 2022

@Sanne at my end I wanted to try out your fix, but I still get the same error. Do you maybe know what I'm doing wrong?

I cloned https://github.com/quarkusio/quarkus

And did

./mvnw -Dquickly

Maybe not necessary, but I also did:

./mvnw install -f extensions/jdbc

Then cloned https://github.com/quarkusio/quarkus-platform and did:

./mvnw install -DskipTests=true

As the last step I changed the version to 999-SNAPSHOT here but still get the same error when I do

mvn package -Pnative

@gsmet
Copy link
Member

gsmet commented Jan 26, 2022

If you want a quick test, just change the groupId of the BOM and Maven plugin from io.quarkus.platform to io.quarkus. This will be OK if you're not using the extra artifacts coming from the Platform.

If you want to test with the Platform, make sure you have updated the Quarkus version in the Platform parent pom. The main branch of the Platform is not targeting 999-SNAPSHOT.

@bvahdat
Copy link

bvahdat commented Jan 30, 2022

@Sanne native build works great now, thanks for fixing that. Now at runtime with native mode I am running into the next problem. Do you maybe have an idea what the problem could be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native build with quarkus-jdbc-oracle + quarkus-jdbc-db2 extension dependencies fails
4 participants