Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LDAP style oracle jdbc url #22452

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Support LDAP style oracle jdbc url #22452

merged 1 commit into from
Dec 21, 2021

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Dec 21, 2021

Fixes #19057

@vsevel vsevel requested a review from Sanne December 21, 2021 16:07
gsmet
gsmet requested changes Dec 21, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's agree on the best approach before merging this.

...dbc-oracle/deployment/src/main/java/io/quarkus/jdbc/oracle/deployment/OracleReflections.java Outdated Show resolved Hide resolved
Sanne
Sanne approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

gsmet
gsmet approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it. Cost is not high and it's not worth adding more complexity.

@vsevel
Copy link
Contributor Author

vsevel commented Dec 21, 2021

Let's merge it. Cost is not high and it's not worth adding more complexity.

@gsmet OK. I am running a few more tests to see if we need methods or fieldsor both.

@vsevel
Copy link
Contributor Author

vsevel commented Dec 21, 2021

yes this works with methods=false and fields=false. let me do a quick change to save some extra bytes.

@vsevel vsevel added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 21, 2021
@vsevel
Copy link
Contributor Author

vsevel commented Dec 21, 2021

@Sanne or @gsmet ready for merge :)

@gsmet gsmet merged commit 29956ca into quarkusio:main Dec 21, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 21, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 21, 2021
@gsmet
Copy link
Member

gsmet commented Dec 21, 2021

Thanks, I'll get this backported on Friday.

@gsmet gsmet mentioned this pull request Dec 21, 2021
Closed
@vsevel vsevel deleted the oracle_ldap branch December 21, 2021 19:40
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.1.Final Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.1.Final
Development

Successfully merging this pull request may close these issues.

Ldap style oracle jdbc urls not supported for native
3 participants
@vsevel @gsmet @Sanne