-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DevServices for Keycloak loading the realm file from the file system #21976
Fix DevServices for Keycloak loading the realm file from the file system #21976
Conversation
Can you add a test for this? |
Hi @stuartwdouglas It is in the linked quickstart PR, I did not want to copy the large realm file here; in |
@stuartwdouglas I can update @geoand 's test once #21999 get merged to use a file system path to the realm file, 3 quickstarts currently use the class based resource for testing. Though having only one of the quickstarts checking the file system path should also be OK IMHO, it will fail if the regression is introduced here before the release... |
839136d
to
7e05fbf
Compare
Hi Stuart, @stuartwdouglas It took me awhile to find where I can add the realm file, with a few tries, but finally, |
Thanks for this @sberyozkin! |
Hi @geoand Can you have a look please since you also worked recently on updating Keycloak Dev Services (and I recall it was a more difficult update than adding a file system bind :-) ) - this PR does that and updates the test |
Should this be backported to |
Thanks for a super fast review @geoand :-) |
Yeah, if it can make it to 2.5.x it would be fine, let me add the labels |
Great, thanks! |
Fixes #21975
(and also removes an unused
shared
property inStartResult
)See also quarkusio/quarkus-quickstarts#1001