add GraalVM native S2I to openshift-s2i-guide.adoc #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text is from quarkus-images/centos-quarkus-native-s2i/README.md (just copy/pasted, with .md converted to .adoc)
cescoffier
approved these changes
Apr 2, 2019
| @@ -39,11 +39,38 @@ oc expose svc/quarkus-quickstart-native | |||
|
|
|||
| # Get the route URL | |||
| export URL="http://$(oc get route | grep quarkus-quickstart-native | awk '{print $2}')" | |||
| echo $URL | |||
There was a problem hiding this comment.
@cescoffier just occurred to me that the text in the following line ("Your application is accessible at the printed URL.") does not really match the "code" (because the curl accesses the app, we don't actually print an URL) - see what I mean? It's of course really minor though, I can remove it again, or leave it, whatever you prefer.
vorburger
added a commit
to vorburger/quarkus-images
that referenced
this pull request
Apr 2, 2019
because most of that content moved to quarkus.git/docs/src/main/asciidoc/openshift-s2i-guide.adoc in quarkusio/quarkus#1801, and we should not have it dupliate in two places.
cescoffier
approved these changes
Apr 2, 2019
cescoffier
added a commit
to quarkusio/quarkus-images
that referenced
this pull request
Jun 24, 2019
* set the exact version for centos * Copy the docker file from the quarkus repository. Add the native-image image Add the distroless image Add the native S2I Also add a graal + maven image * align how dockerfile retrieve graalvm * update to GraalVM 1.0.0-rc14 * document pre-built native-s2i from http://Quay.io in README.md * add WORKDIR to centos-quarkus-native-s2i/Dockerfile suggested on josequaresma/quarkus@5d357f7 by @josequaresma and should "remove the error with application not being able to create quarkus.log" which was brought up on #1 (according to @josequaresma) * simplify centos-quarkus-native-s2i/README.md because most of that content moved to quarkus.git/docs/src/main/asciidoc/openshift-s2i-guide.adoc in quarkusio/quarkus#1801, and we should not have it dupliate in two places. * update to graalvm-1.0.0-rc15 * Changed to use a fixed name for the native application in the container. Fixes #11 * Add a readme explaining how this repo is used * Update GraalVM (RC16) and Maven (3.6.1) versions * Add a note about changing the default branch of the repository in the README * quarkus images, cekit poc Signed-off-by: Filippe Spolti <fspolti@redhat.com> * Add a task goal * Creates a common module installing the base packages * the image providing maven and other tools need is still based on centos * Use ubi-minimal * fix typo * Fix the quarkus user test in the native-image image * Rename modules * Create a gradle module * Change version * Change modules names Avoid overriding the version * Remove the dependency of the push phase * fix image name in the Makefile * Add support for GrallVM 19.0.2 * Use GraalVM 19.0.2 * Update version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cescoffier @tqvarnst @siamaksade OK for you?