Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ApplicationConfig uses the correct resource dir #1695

Closed
wants to merge 1 commit into from

Conversation

stalep
Copy link
Member

@stalep stalep commented Mar 26, 2019

No description provided.

@geoand
Copy link
Contributor

geoand commented Mar 26, 2019

I admit I have missed the recent gradle changes but I am still not sure if this will work correctly, because the "reading" part of the code is: https://github.com/quarkusio/quarkus/blob/master/core/deployment/src/main/java/io/quarkus/deployment/steps/ApplicationInfoBuildStep.java#L47

Now that I think of it, maybe the change isn't even needed and things will work as is?

Let me try a sample gradle project and get back to you

@geoand
Copy link
Contributor

geoand commented Mar 26, 2019

So I tried the gradle app without the PR and the new BuildItem (ApplicationInfoBuildItem) added in #1683 works just fine. With the change here it does not work (basically the defaults of name and version are not properly set), I guess because the Classloader on the reading side does not know where to find the resource.

In any case, this properties file is strictly internal, it should never be even be seen by users and is only used in order to populate a BuildItem.
Furthermore, this is a temporary solution until #1693 comes up with a holistic approach

@stalep
Copy link
Member Author

stalep commented Mar 26, 2019

hm, ok. ill close this, i just thought it should continue to use the default resource folder defined by each build system. lets discuss this further in #1693

@stalep stalep closed this Mar 26, 2019
@gsmet gsmet added the triage/invalid This doesn't seem right label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants