-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection handling fixes #14305
Merged
Merged
Connection handling fixes #14305
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1deece0
Test the transaction lifecycle (session flushes, session closing, ...)
yrodiere 373042f
Test warnings when executing StoredProcedureQuery (#13273)
yrodiere 13696e9
Set Hibernate ORM connection handling strategy to BEFORE_TRANSACTION_…
Sanne d39f754
Simplify connection handling setup and add a note about #7242
yrodiere a488c71
Let Hibernate ORM handle the flush/close after a transaction
yrodiere 3756ff8
Let the session join JTA transactions implicitly
yrodiere d9ed7bc
Allow setting a different connection handling mode and auto-close mod…
yrodiere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B. that semantics is not the same: the key can be defined while the value is set to null. No? Or is the change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a problem here, it's probably also a problem just above, where we use
cfg.containsKey
to check whether a property is defined or not.If we're going to worry about this, I think what we need to ask is: how would we end up in a situation where a property is set, but its value is
null
? From what I understand the only way for properties to be pre-set here is from apersistence.xml
. I'm not sure if you can set something tonull
frompersistence.xml
?