Create Kubernetes extension #1300

geoand · 2019-03-07T13:07:57Z

Fixes: #565

This supersedes #1031

emmanuelbernard · 2019-03-07T15:13:21Z

We should all read the guide doc and then have a conversation on how we want to best surface the Kubernetes concept in Quarkus apps to exploits what ap4k generates.

geoand · 2019-03-07T15:26:41Z

@emmanuelbernard 👍

geoand · 2019-03-07T15:46:25Z

cc @iocanel

geoand · 2019-03-11T13:10:51Z

This would also fix #1382

devtools/common/src/main/filtered/extensions.json

gsmet

@geoand I added some comments for the guide.

docs/src/main/asciidoc/ap4k.adoc

geoand · 2019-03-11T14:58:23Z

@gsmet Thanks for the thorough review! I will address the concerns later on tonight.

geoand · 2019-03-11T19:03:59Z

@gsmet I addresses the comments from your review

core/deployment/src/main/java/io/quarkus/deployment/BuildInfo.java

gsmet · 2019-03-13T00:08:52Z

@geoand I added one more comment and there's a conflict, could you rebase?

@stuartwdouglas @emmanuelbernard I'm tempted to merge this one once @geoand has fixed the last minor issues and iterate from here. Do you have any reservations about it?

geoand · 2019-03-13T05:45:11Z

@gsmet PR rebased

extensions/ap4k/deployment/src/main/java/io/quarkus/ap4k/deployment/Ap4kProcessor.java

gsmet · 2019-03-13T11:49:57Z

@geoand sorry I spotted one last typo. Could you fix it and squash everything? Let's avoid commits like "Fix broken rebase" in the history.

I will start a thread on the list to discuss this subject as I'm not totally sure what Emmanuel wanted to say in its message (that's the reason I haven't merged it yet).

geoand · 2019-03-13T11:50:44Z

@geoand sorry I spotted one last typo. Could you fix it and squash everything? Let's avoid commits like "Fix broken rebase" in the history.

I will start a thread on the list to discuss this subject as I'm not totally sure what Emmanuel wanted to say in its message (that's the reason I haven't merged it yet).

@gsmet I am generally in favor of each PR being a single commit :)

geoand · 2019-03-13T11:51:41Z

@gsmet comment addressed and commits squashed

gsmet

I will start a discussion on the ML to address Emmanuel's comment. Other than that, it looks like a nice addition and something people want.

geoand · 2019-03-13T11:53:31Z

@gsmet Sounds good :)

geoand · 2019-03-14T21:38:00Z

@gsmet was there any verdict in this perhaps?

Thanks

gsmet · 2019-03-14T21:41:50Z

@geoand well, not really, see Emmanuel's post on the quarkus-dev list.

gsmet · 2019-03-14T21:44:32Z

Quoting @emmanuelbernard:

We wanted to discuss the use of annotations vs properties in the context of Quarkus for the integration with Kubernetes. To find whatever felt more natural. I can't drive that conversation right now but David had some possible opinions.

geoand · 2019-03-15T05:34:46Z

Thanks, I must have missed the discussion

geoand · 2019-03-27T09:05:37Z

@dmlloyd @iocanel would you prefer that I remove the docker build and resource application capabilities (thus removing the extra properties from ApplicationInfoBuildItem) thus keeping things cleaner and focus only on resource generation?

dmlloyd · 2019-03-27T12:36:29Z

Sure, that sounds like a reasonable first step. Introducing things incrementally is definitely easier when it can be done.

iocanel · 2019-03-27T13:53:19Z

@geoand: Generally speaking, I prefer the approach of adding staff gradually, as it makes the review process so much easier.

Now, in the particular case (where they have been added already), it's up to you and @dmlloyd to figure how to proceed.

geoand · 2019-03-27T13:57:33Z

I just pushed a commit that leaves only the basic resource generation functionality in. Please take a look

dmlloyd · 2019-03-27T14:09:17Z

Pending CI

geoand · 2019-03-27T14:16:41Z

This is currently still work in progress because I see that bringing in the extension results in all of it's dependencies being added to the generated lib directory (that didn't use to be the case) but I guess the bootstrapping work has changed things

dmlloyd

OK I'll hold off on approval then until you're ready.

Change is not ready yet after all.

geoand · 2019-03-27T14:20:45Z

Thanks. I think I will need to add a runtime artifact that doesn't do have any actual code, but will help the boostraping mechanism correctly figure out the dependencies

geoand · 2019-03-27T14:52:52Z

I added another commit that fixes the dependencies issue, so this is now good to go

geoand · 2019-03-27T15:08:41Z

@iocanel mind taking one last look as well?

...ubernetes/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java

iocanel · 2019-03-27T15:16:57Z

...ubernetes/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java

+    private Map<String, Integer> verifyPorts(List<KubernetesPortBuildItem> kubernetesPortBuildItems) {
+        final Map<String, Integer> result = new HashMap<>();
+        final Set<Integer> usedPorts = new HashSet<>();
+        for (KubernetesPortBuildItem entry : kubernetesPortBuildItems) {


Really like the fact that we perform this verification!

The more build time errors the better :)

iocanel

LGTM

This allows users to set a desired name for the applications (using quarkus.application.name) or version. The idea came from: quarkusio/quarkus#1300 (comment) and this configuration is meant to be used by extensions that for some reason need this information (like the planned kubernetes extension)

geoand mentioned this pull request Mar 7, 2019

Create ap4k extension #1031

Closed

This was referenced Mar 7, 2019

Provide Dockerfile files for both JVM and Native modes #1312

Merged

Why quarkus does not generate basic k8s deployment file #1382

Closed

gsmet reviewed Mar 11, 2019

View reviewed changes

devtools/common/src/main/filtered/extensions.json Outdated Show resolved Hide resolved

gsmet requested changes Mar 11, 2019

View reviewed changes

gsmet reviewed Mar 13, 2019

View reviewed changes

core/deployment/src/main/java/io/quarkus/deployment/BuildInfo.java Outdated Show resolved Hide resolved

geoand force-pushed the ap4k branch from 3750cea to d68e5f2 Compare March 13, 2019 05:44

geoand requested a review from gsmet March 13, 2019 08:12

gsmet reviewed Mar 13, 2019

View reviewed changes

extensions/ap4k/deployment/src/main/java/io/quarkus/ap4k/deployment/Ap4kProcessor.java Outdated Show resolved Hide resolved

geoand force-pushed the ap4k branch from bbde4f1 to f49af61 Compare March 13, 2019 11:51

geoand requested a review from gsmet March 13, 2019 11:51

gsmet previously approved these changes Mar 13, 2019

View reviewed changes

gsmet added the triage/on-ice Frozen until external concerns are resolved label Mar 14, 2019

geoand force-pushed the ap4k branch from f49af61 to 5306c22 Compare March 15, 2019 15:29

geoand force-pushed the ap4k branch from ed15988 to 1bb5806 Compare March 27, 2019 14:01

Keep only resource generation in the ap4k + kubernetes integration

40c3f7a

geoand force-pushed the ap4k branch from 1bb5806 to 40c3f7a Compare March 27, 2019 14:06

dmlloyd previously approved these changes Mar 27, 2019

View reviewed changes

dmlloyd reviewed Mar 27, 2019

View reviewed changes

Add runtime module to fix dependencies issue

e134d42

geoand removed the coding-in-progress label Mar 27, 2019

dmlloyd approved these changes Mar 27, 2019

View reviewed changes

iocanel reviewed Mar 27, 2019

View reviewed changes

...ubernetes/deployment/src/main/java/io/quarkus/kubernetes/deployment/KubernetesProcessor.java Outdated Show resolved Hide resolved

iocanel reviewed Mar 27, 2019

View reviewed changes

Use kubernetes resources directory instead of ap4k

0e9c4f9

iocanel approved these changes Mar 27, 2019

View reviewed changes

geoand merged commit f519389 into quarkusio:master Mar 27, 2019

geoand deleted the ap4k branch March 27, 2019 16:54

gsmet added this to the 0.13.0 milestone Apr 2, 2019

gsmet changed the title ~~Create ap4k extension~~ Create Kubernetes extension Apr 2, 2019

gsmet added the release/noteworthy-feature label Apr 2, 2019

maxandersen pushed a commit to maxandersen/quarkus that referenced this pull request Nov 5, 2022

fix: don't copy classpath files more than once (quarkusio#1300)

6337f4e

snowe2010 mentioned this pull request Jan 7, 2023

Unable to push to registry due to group requirement #30240

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Kubernetes extension #1300

Create Kubernetes extension #1300

geoand commented Mar 7, 2019

emmanuelbernard commented Mar 7, 2019

geoand commented Mar 7, 2019

geoand commented Mar 7, 2019

geoand commented Mar 11, 2019

gsmet left a comment

geoand commented Mar 11, 2019

geoand commented Mar 11, 2019

gsmet commented Mar 13, 2019

geoand commented Mar 13, 2019

gsmet commented Mar 13, 2019

geoand commented Mar 13, 2019

geoand commented Mar 13, 2019

gsmet left a comment

geoand commented Mar 13, 2019

geoand commented Mar 14, 2019

gsmet commented Mar 14, 2019

gsmet commented Mar 14, 2019

geoand commented Mar 15, 2019

geoand commented Mar 27, 2019 •

edited

Loading

dmlloyd commented Mar 27, 2019

iocanel commented Mar 27, 2019

geoand commented Mar 27, 2019

dmlloyd commented Mar 27, 2019

geoand commented Mar 27, 2019

dmlloyd left a comment

geoand commented Mar 27, 2019

geoand commented Mar 27, 2019

geoand commented Mar 27, 2019

iocanel Mar 27, 2019

geoand Mar 27, 2019

iocanel left a comment

Create Kubernetes extension #1300

Create Kubernetes extension #1300

Conversation

geoand commented Mar 7, 2019

emmanuelbernard commented Mar 7, 2019

geoand commented Mar 7, 2019

geoand commented Mar 7, 2019

geoand commented Mar 11, 2019

gsmet left a comment

Choose a reason for hiding this comment

geoand commented Mar 11, 2019

geoand commented Mar 11, 2019

gsmet commented Mar 13, 2019

geoand commented Mar 13, 2019

gsmet commented Mar 13, 2019

geoand commented Mar 13, 2019

geoand commented Mar 13, 2019

gsmet left a comment

Choose a reason for hiding this comment

geoand commented Mar 13, 2019

geoand commented Mar 14, 2019

gsmet commented Mar 14, 2019

gsmet commented Mar 14, 2019

geoand commented Mar 15, 2019

geoand commented Mar 27, 2019 • edited Loading

dmlloyd commented Mar 27, 2019

iocanel commented Mar 27, 2019

geoand commented Mar 27, 2019

dmlloyd commented Mar 27, 2019

geoand commented Mar 27, 2019

dmlloyd left a comment

Choose a reason for hiding this comment

geoand commented Mar 27, 2019

geoand commented Mar 27, 2019

geoand commented Mar 27, 2019

iocanel Mar 27, 2019

Choose a reason for hiding this comment

geoand Mar 27, 2019

Choose a reason for hiding this comment

iocanel left a comment

Choose a reason for hiding this comment

geoand commented Mar 27, 2019 •

edited

Loading