Conflicting warnings when building an uberjar with deprecated property quarkus.package.type=uber-jar

[gsmet]

When building an uberjar with quarkus.package.type=uber-jar, we end up with the following warnings:

[WARNING] [io.quarkus.deployment.configuration] Configuration property 'quarkus.package.type' has been deprecated and replaced by: [quarkus.package.jar.enabled, quarkus.package.jar.type, quarkus.native.enabled, quarkus.native.sources-only]
[WARNING] [io.quarkus.config] Unrecognized configuration key "quarkus.package.type" was provided; it will be ignored; verify that the dependency extension for this configuration is set or that you did not make a typo
[INFO] [io.quarkus.deployment.pkg.steps.JarResultBuildStep] Building uber jar: /home/gsmet/git/monitor-artifact-publication-action/target/monitor-artifact-publication-action-999-SNAPSHOT-runner.jar

Given an uberjar is actually built, I think the second warning is not ideal as it's saying the configuration will be ignored, which is untrue.
I haven't checked exactly how this change was implemented but maybe we should keep the old deprecated config around to avoid the second warning?

/cc @dmlloyd

[dmlloyd]

Hmm I haven't seen the second warning come up before. Let me look into how that happens; it should be covered by the ignored config keys set, but there are multiple code paths for validating config IIRC.

[gsmet]

If it can be of help, I was building https://github.com/quarkusio/monitor-artifact-publication-action , updated to io.quarkus:quarkus-bom:999-SNAPSHOT with mvn clean package -Dquarkus.package.type=uber-jar -DskipTests.

[dmlloyd]

I didn't get the second warning, but I did get this error:

[INFO] --- quarkus:999-SNAPSHOT:build (default) @ monitor-artifact-publication-action ---
[WARNING] [io.quarkus.deployment.configuration] Configuration property 'quarkus.package.type' has been deprecated and replaced by: [quarkus.package.jar.enabled, quarkus.package.jar.type, quarkus.native.enabled, quarkus.native.sources-only]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.117 s
[INFO] Finished at: 2024-04-12T11:05:09-05:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal io.quarkus.platform:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project monitor-artifact-publication-action: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[ERROR] 	[error]: Build step io.quarkus.rest.client.reactive.deployment.RestClientReactiveProcessor#announceFeature threw an exception: java.lang.NoSuchFieldError: REST_CLIENT_REACTIVE
[ERROR] 	at io.quarkus.rest.client.reactive.deployment.RestClientReactiveProcessor.announceFeature(RestClientReactiveProcessor.java:140)
[ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[ERROR] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[ERROR] 	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
[ERROR] 	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
[ERROR] 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
[ERROR] 	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2516)
[ERROR] 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2495)
[ERROR] 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1521)
[ERROR] 	at java.base/java.lang.Thread.run(Thread.java:840)
[ERROR] 	at org.jboss.threads.JBossThread.run(JBossThread.java:483)
[ERROR] -> [Help 1]

This is with a fresh Quarkus build. Did I miss something?

[gsmet]

@dmlloyd Sorry I missed your message. Make sure you adjust the groupId to io.quarkus here: https://github.com/quarkusio/monitor-artifact-publication-action/blob/main/pom.xml#L18.

You are probably using an old platform you released before.

FWIW, probably a good idea to get a fix for that before Monday so that the .0 doesn't have this issue.

[gsmet]

@dmlloyd here are the changes that should be applied to trigger the warning with main: quarkusio/monitor-artifact-publication-action#43

[dmlloyd]

Ah I needed to update my monitor-artifact-publication-action checkout. I was able to reproduce the problem.