Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC: Built in quarkus-maven compiler doesn't seem to handle subfolders of protos in external dependency #36078

Closed
tmulle opened this issue Sep 21, 2023 · 1 comment · Fixed by #36153
Assignees
Labels
area/grpc gRPC area/maven kind/bug Something isn't working
Milestone

Comments

@tmulle
Copy link
Contributor

tmulle commented Sep 21, 2023

Describe the bug

In a nutshell, we have an external dependency that has our base protos under a subfolder and we want to pull those into our project and compile those and the project specific ones.

However, the protoc/grpc compiler doesn't appear to handle subfolders like expected.

Or we are just configuring things wrong based on our understanding of the docs.

I've explained it all here with a reproducer.

https://github.com/tmulle/quarkus-grpc-import-test

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

3.4.1

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@tmulle tmulle added the kind/bug Something isn't working label Sep 21, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 21, 2023

/cc @alesj (grpc), @cescoffier (grpc), @quarkusio/devtools (maven)

@cescoffier cescoffier self-assigned this Sep 25, 2023
cescoffier added a commit to cescoffier/quarkus that referenced this issue Sep 26, 2023
Fix missing include statements in the proto compilation and also improve the syntax of the proto include/exclude clauses (comma-separated list accepting spaces)
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 28, 2023
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Feb 8, 2024
Fix missing include statements in the proto compilation and also improve the syntax of the proto include/exclude clauses (comma-separated list accepting spaces)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC area/maven kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants