-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure OTel receives standard duration string properties #33381
Labels
Milestone
Comments
/cc @radcortez (opentelemetry,tracing) |
hi @brunobat, how are you? |
I see that you opened a PR. Many thanks for that. Will take a look. |
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Aug 1, 2023
geoand
added a commit
to geoand/quarkus
that referenced
this issue
Aug 1, 2023
geoand
added a commit
that referenced
this issue
Aug 2, 2023
Convert duration properties into a format OTel can parse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Following up this PR:
#33326
We identified that OTel does not understand some of the Quarkus defined duration properties due to be more permissive.
We need a transformation to normalize all duration values to something OTel will accept.
Implementation ideas
This should be done around here: https://github.com/quarkusio/quarkus/blob/de16f435b6e3112fc73b0f032a98e0e838739dab/extensions/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/OpenTelemetryProducer.java#LL157C26-L157C26
Or use converters in each prop... This would be cleaner.
The text was updated successfully, but these errors were encountered: