Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure OTel receives standard duration string properties #33381

Closed
brunobat opened this issue May 15, 2023 · 3 comments · Fixed by #35139
Closed

Make sure OTel receives standard duration string properties #33381

brunobat opened this issue May 15, 2023 · 3 comments · Fixed by #35139
Assignees
@geoand
Labels
area/tracing good first issue Good for newcomers kind/enhancement New feature or request
Milestone
3.3.0.CR1

Comments

@brunobat
Copy link
Contributor

brunobat commented May 15, 2023 •
edited
Loading

Description

Following up this PR:
#33326

We identified that OTel does not understand some of the Quarkus defined duration properties due to be more permissive.
We need a transformation to normalize all duration values to something OTel will accept.

Implementation ideas

This should be done around here: https://github.com/quarkusio/quarkus/blob/de16f435b6e3112fc73b0f032a98e0e838739dab/extensions/opentelemetry/runtime/src/main/java/io/quarkus/opentelemetry/runtime/OpenTelemetryProducer.java#LL157C26-L157C26

Or use converters in each prop... This would be cleaner.
@brunobat brunobat added the kind/enhancement New feature or request label May 15, 2023
@brunobat brunobat mentioned this issue May 15, 2023
Merged
@quarkus-bot
Copy link

quarkus-bot bot commented May 15, 2023

/cc @radcortez (opentelemetry,tracing)

@brunobat brunobat added the good first issue Good for newcomers label May 15, 2023
@mcruzdev
Copy link
Contributor

mcruzdev commented Jun 4, 2023 •
edited
Loading

hi @brunobat, how are you?
can I help with it? It will be great to get it

@mcruzdev mcruzdev mentioned this issue Jun 8, 2023
Closed
@brunobat
Copy link
Contributor Author

brunobat commented Jun 9, 2023

I see that you opened a PR. Many thanks for that. Will take a look.

geoand added a commit to geoand/quarkus that referenced this issue Aug 1, 2023
@geoand
Convert duration properties into a format OTel can parse
afbbace 
Fixes: quarkusio#33381
@geoand geoand mentioned this issue Aug 1, 2023
Merged
geoand added a commit to geoand/quarkus that referenced this issue Aug 1, 2023
@geoand
Convert duration properties into a format OTel can parse
2014dc9 
Fixes: quarkusio#33381
@geoand geoand self-assigned this Aug 1, 2023
geoand added a commit that referenced this issue Aug 2, 2023
@geoand
Merge pull request #35139 from geoand/#33381
f78c8a9 
Convert duration properties into a format OTel can parse
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/tracing good first issue Good for newcomers kind/enhancement New feature or request
Projects
Quarkus Roadmap/Planning
Status: Done
Milestone
3.3.0.CR1
3 participants
@brunobat @geoand @mcruzdev