Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute: extension tags not registered #21864

Closed
FroMage opened this issue Dec 1, 2021 · 5 comments · Fixed by #22037
Closed

Qute: extension tags not registered #21864

FroMage opened this issue Dec 1, 2021 · 5 comments · Fixed by #22037
Assignees
Labels
area/qute The template engine kind/bug Something isn't working
Milestone

Comments

@FroMage
Copy link
Member

FroMage commented Dec 1, 2021

Describe the bug

I just tried the latest Quarkus/Qute to see if it would pick up my Vixen extension tags, declared in extensions/vixen/runtime/src/main/resources/templates/tags (in the runtime module) and they're not visible to the user application, I'm getting errors.

Perhaps I'm doing it wrong and they need to be in the deployment module?

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@FroMage FroMage added kind/bug Something isn't working area/qute The template engine labels Dec 1, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 1, 2021

/cc @mkouba

@mkouba
Copy link
Contributor

mkouba commented Dec 7, 2021

Perhaps I'm doing it wrong and they need to be in the deployment module?

No, it should be the runtime module. Let me check..

@mkouba mkouba self-assigned this Dec 7, 2021
mkouba added a commit to mkouba/quarkus that referenced this issue Dec 8, 2021
mkouba added a commit to mkouba/quarkus that referenced this issue Dec 9, 2021
- resolves quarkusio#21864

Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
mkouba added a commit to mkouba/quarkus that referenced this issue Dec 9, 2021
- resolves quarkusio#21864

Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 9, 2021
Postremus pushed a commit to Postremus/quarkus that referenced this issue Dec 10, 2021
- resolves quarkusio#21864

Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
@FroMage
Copy link
Member Author

FroMage commented Dec 13, 2021

OK, this fixes my bug. Do you have any need for a tag build item then? FroMage@59440da

Or should I drop this commit from my branch?

@mkouba
Copy link
Contributor

mkouba commented Dec 13, 2021

Or should I drop this commit from my branch?

I don't think that we need the TemplateTagBuildItem so +1..

@FroMage
Copy link
Member Author

FroMage commented Dec 13, 2021

OK thanks.

@gsmet gsmet modified the milestones: 2.7 - main, 2.6.0.Final Dec 13, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Dec 13, 2021
- resolves quarkusio#21864

Co-authored-by: George Gastaldi <gegastaldi@gmail.com>
(cherry picked from commit 965ec14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants