-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qute: tag parameters from outer space #21861
Comments
/cc @mkouba |
This should not happen unless a value resolver is generated for the
So we'll need more context here to reproduce the problem. Anyway, it should be easy to fix - set the priority used for the default
Yes, this one comes from the parent context, namely the from the data map passed to the template. Again, should be easy to fix the default behavior - wrap the map with a
I'm not sure TBH. The current behavior is that you can access the data from the parent/outer context because we thought that it might be useful. We could implement a breaking change and disable the access by default but then we should probably make it configurable, i.e. some special attribute |
- i.e. for params that define no key and contain only single part - also use Mapper instead of Map for the data passed to a template - Mapper value resolver has priority 15, i.e. is called before a generated value resolver - resolves quarkusio#21855 - related to quarkusio#21861
- i.e. for params that define no key and contain only single part - also use Mapper instead of Map for the data passed to a template - Mapper value resolver has priority 15, i.e. is called before a generated value resolver - resolves quarkusio#21855 - related to quarkusio#21861
How can I find which resolver prints this, then?
I assume this is done by Qute itself, right?
Wait, parent context of what? The tag? So you can access data from outside the tag itself? Not just its parameters? |
- i.e. for params that define no key and contain only single part - also use Mapper instead of Map for the data passed to a template - Mapper value resolver has priority 15, i.e. is called before a generated value resolver - resolves quarkusio#21855 - related to quarkusio#21861
Describe the bug
This one is funky:
test.html:
Usage:
{#test class="myclass"/}
Result:
So… I can't use the
class
parameter name, I need to useklass
in order to be able to pass my values. And for some reason, if I don't specify asize
parameter on the call site, the tag still has a value for it, so it can't test whether it was passed or not withsize??
and it appears pretty random from the PoV of the user.I know @mkouba told me there's a place where this
size
comes from, and there might be other reserved parameter names that are tricky like this, but we should probably remove them because they can really clash with what the user is doing. Unless there's a good reason for them existing?Expected behavior
No response
Actual behavior
No response
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: