Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration property to disable http access log for certain routes #13377

Closed
rohit-s8 opened this issue Nov 19, 2020 · 9 comments · Fixed by #16891
Closed

Add configuration property to disable http access log for certain routes #13377

rohit-s8 opened this issue Nov 19, 2020 · 9 comments · Fixed by #16891

Comments

@rohit-s8
Copy link

Description
Quarkus provides a way to log the http calls being made to it via the config property quarkus.http.access-log.enabledand this is just fine. However, in a kubernetes environment, this usually means that all the liveness and readiness probes also get logged which makes the logs very messy (IMO). So it would be great if there was a property like quarkus.http.access-log.disabled-routes where we specify which routes will not be logged and for good measure, this can be defaulted to routes like /health, /health/live, /health/ready and /metrics.

Implementation ideas

@rohit-s8 rohit-s8 added the kind/enhancement New feature or request label Nov 19, 2020
@ghost ghost added the area/kubernetes label Nov 19, 2020
@ghost
Copy link

ghost commented Nov 19, 2020

/cc @geoand

@geoand
Copy link
Contributor

geoand commented Nov 19, 2020

I think this makes sense.

WDYT @stuartwdouglas @cescoffier @kenfinnigan @ebullient ?

@ebullient
Copy link
Member

y. A similar mechanism exists in micrometer to exclude urls.

I don't know that I would exclude them by default. It can be the easiest first check that things are working properly (even before your endpoint works).

@kenfinnigan
Copy link
Member

Probably should be a follow on from #13144 to make it easier as it can be anything under the endpoint prefix is ignored

@rohit-s8
Copy link
Author

I don't see anything in #13144 that talks about configuring logging for non application endpoints.

@akoufa
Copy link

akoufa commented Apr 28, 2021

Hello to all. Is there any update on this ? Is this possible now ?

stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Apr 28, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 30, 2021
@daurrutia
Copy link

Any chance there'd be an example for path such as /auth/resources/nje61/...?

@tweinreich
Copy link
Contributor

Any chance there'd be an example for path such as /auth/resources/nje61/...?

When you take a look at the code it is just a regex. For your example it would be /auth/resources/nje61/.*

I know this reply is late but I want to add it in case someone else is searching for an example (maybe it could be added to the documentation / tutorials).

@geoand
Copy link
Contributor

geoand commented Feb 8, 2023

maybe it could be added to the documentation

Documentation enhancements are always welcome!
This is the where such an example could be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants