Avoid using a dynamic regexp

quarkusio · Aug 27, 2024 · 7325188 · 7325188
1 parent 14b98e3
commit 7325188
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/devtools/cli/src/main/java/io/quarkus/cli/QuarkusCli.java b/devtools/cli/src/main/java/io/quarkus/cli/QuarkusCli.java
@@ -12,7 +12,6 @@
 import java.util.Optional;
 import java.util.concurrent.Callable;
 import java.util.function.Supplier;
-import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 
 import jakarta.inject.Inject;
@@ -178,7 +177,7 @@ public Optional<String> checkMissingCommand(CommandLine root, String[] args) {
                 if (!unmatchedSubcommands.isEmpty()) {
                     missingCommand.append("-").append(unmatchedSubcommands.get(0));
                     // We don't want the root itself to be added to the result
-                    return Optional.of(missingCommand.toString().replaceFirst(Pattern.quote(root.getCommandName() + "-"), ""));
+                    return Optional.of(stripRootPrefix(missingCommand.toString(), root.getCommandName() + "-"));
                 }
 
                 currentParseResult = currentParseResult.subcommand();
@@ -195,6 +194,14 @@ public Optional<String> checkMissingCommand(CommandLine root, String[] args) {
         }
     }
 
+    private static String stripRootPrefix(String command, String rootPrefix) {
+        if (!command.startsWith(rootPrefix)) {
+            return command;
+        }
+
+        return command.substring(rootPrefix.length());
+    }
+
     @Override
     public Integer call() throws Exception {
         output.info("%n@|bold Quarkus CLI|@ version %s", Version.clientVersion());