Merge pull request #31384 from radcortez/config-docs-ignore-default-m…

…ethods Ignore required documentation for @ConfigMapping default methods
quarkusio · Mar 2, 2023 · 2574aa7 · 2574aa7
2 parents 6512270 + 92a7804
commit 2574aa7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/...processor/src/main/java/io/quarkus/annotation/processor/ExtensionAnnotationProcessor.java b/...processor/src/main/java/io/quarkus/annotation/processor/ExtensionAnnotationProcessor.java
@@ -512,20 +512,22 @@ private void processCtorConfigItem(ExecutableElement ctor, Properties javadocPro
         final String docComment = getRequiredJavadoc(ctor);
         final StringBuilder buf = new StringBuilder();
         appendParamTypes(ctor, buf);
-        javadocProps.put(className + Constants.DOT + buf.toString(), docComment);
+        javadocProps.put(className + Constants.DOT + buf, docComment);
     }
 
     private void processMethodConfigItem(ExecutableElement method, Properties javadocProps, String className) {
         final String docComment = getRequiredJavadoc(method);
         final StringBuilder buf = new StringBuilder();
         buf.append(method.getSimpleName().toString());
         appendParamTypes(method, buf);
-        javadocProps.put(className + Constants.DOT + buf.toString(), docComment);
+        javadocProps.put(className + Constants.DOT + buf, docComment);
     }
 
     private void processMethodConfigMapping(ExecutableElement method, Properties javadocProps, String className) {
-        final String docComment = getRequiredJavadoc(method);
-        javadocProps.put(className + Constants.DOT + method.getSimpleName().toString(), docComment);
+        if (method.getModifiers().contains(Modifier.ABSTRACT)) {
+            final String docComment = getRequiredJavadoc(method);
+            javadocProps.put(className + Constants.DOT + method.getSimpleName().toString(), docComment);
+        }
     }
 
     private void processConfigGroup(RoundEnvironment roundEnv, TypeElement annotation) {

diff --git a/...xtension/runtime/src/main/java/io/quarkus/extest/runtime/config/TestMappingBuildTime.java b/...xtension/runtime/src/main/java/io/quarkus/extest/runtime/config/TestMappingBuildTime.java
@@ -46,4 +46,8 @@ interface Group {
          */
         String value();
     }
+
+    default void mustNotRequireDocs() {
+
+    }
 }