Enable Quarkus Observability Dev Services with Grafana LGTM in OpenTelemetry Quickstart

[jcarranzan]

Resolve the issue that we discussed here: https://issues.redhat.com/browse/QUARKUS-4186
I am adding support for automatic metrics and tracing in development mode.

Check list:

Your pull request:

• targets the development branch
• uses the 999-SNAPSHOT version of Quarkus
• has tests (mvn clean test)
• works in native (mvn clean package -Pnative)
• has integration/native tests (mvn clean verify -Pnative)
• makes sure the associated guide must not be updated
• links the guide update pull request (if needed)
• updates or creates the README.md file (with build and run instructions)
• for new quickstart, is located in the directory component-quickstart
• for new quickstart, is added to the root pom.xml and README.md

[jcarranzan]

@brunobat

[brunobat]

Hi @jcarranzan.
Thanks for the PR but we must not mix Micrometer related dependencies into the OpenTelemetry Quickstart.
I have 2 suggestions:

1. Use OpenTelemetry Metrics instead
2. Create a new Observability Quickstart that includes both OpenTelemetry and Micrometer.

We should probably have both, but in the context of this PR I recommend the first one.

[brunobat]

Almost there. Thanks for the effort.

[brunobat]

@jcarranzan Do you think you can update the Readme, explaining that metrics must be enabled and that the user can use the LGTM devservice to see the telemetry?

[brunobat]

Did manual tests... Native tests fails because the devservice starts while running the native mode tests. I'm checking it with @alesj

[alesj]

I guess you need to add

@DisabledOnOs(OS.WINDOWS)

to the IT test.

[brunobat]

@alesj, but It happened to me on a mac...

[jcarranzan]

Any update on this @alesj @brunobat? should we open an issue or is it solved? thanks.

[alesj]

It's fixed in my PR (#44158), waiting on @brunobat to merge it.

[jcarranzan]

@brunobat could it be merged to have this tested and verified?

[brunobat]

@jcarranzan quarkusio/quarkus#44158 still has unresolved issues. Will not be merged this week.

[rsvoboda]

quarkusio/quarkus#44158 is about integration tests changes, how does it relate to this PR @brunobat ?

[brunobat]

Because native mode tests are broken when the Grafana LGTM extension is in the classpath. We were not testing that and the PR fixes it. We need that fix to pass the native mode tests in the Quickstart.

[michalvavrik]

Because native mode tests are broken when the Grafana LGTM extension is in the classpath. We were not testing that and the PR fixes it. We need that fix to pass the native mode tests in the Quickstart.

I am asking just out of interested, this is not matter of pushing this forward. I simply don't understand this answer. I look at POM file used by this PR https://github.com/quarkusio/quarkus-quickstarts/blob/db74c8e9a2adf07ad3e00949ce919c33a3ed3f2c/opentelemetry-quickstart/pom.xml and then I check PR you linked quarkusio/quarkus#44158 which is only in integration-tests/observability-lgtm. So I cannot understand how current state of quarkusio/quarkus#44158 could fix anything here. Could you help me to understand? Or maybe you are just saying that fix is coming and is not yet in 44158.

[brunobat]

Because native mode tests are broken when the Grafana LGTM extension is in the classpath. We were not testing that and the PR fixes it. We need that fix to pass the native mode tests in the Quickstart.

I am asking just out of interested, this is not matter of pushing this forward. I simply don't understand this answer. I look at POM file used by this PR https://github.com/quarkusio/quarkus-quickstarts/blob/db74c8e9a2adf07ad3e00949ce919c33a3ed3f2c/opentelemetry-quickstart/pom.xml and then I check PR you linked quarkusio/quarkus#44158 which is only in integration-tests/observability-lgtm. So I cannot understand how current state of quarkusio/quarkus#44158 could fix anything here. Could you help me to understand? Or maybe you are just saying that fix is coming and is not yet in 44158.

You are right, @michalvavrik. The fact that native was broken on the Quarkus repo diverted my attention from the main issue here. Please check my comment above, it will unlock the PR.

[brunobat]

Thanks for the PR and patience @jcarranzan.
The users will benefit from this update.

[quarkus-bot]

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 45b0321.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.