-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mandrel 21.3.3.0-Final and 22.2.0.0-Final July 2022 CPU #202
Mandrel 21.3.3.0-Final and 22.2.0.0-Final July 2022 CPU #202
Conversation
@zakkak @cescoffier https://github.com/graalvm/mandrel/releases/tag/mandrel-22.2.0.0-Final might have been in DRAFT state the second this CI was started, so if the download fails, restart the CI, please... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Karm!
I think we should remove 22.0 mandrel modules at this point, in case you want to squeeze it in the same commit.
How about we do a cleanup with the LTS? Like "when LTS comes, all previous in that major are dropped". |
I recall having some issues with keeping that many images up to date, but I don't recall what the issue was. @cescoffier might have a better memory :) |
The deployment will fail, unfortunately. The whole deployment process is broken since multi-archs. Look at the multi-archs branch, which proposes a completely new approach to building the images. |
I've seen the multi-archs branch. Not sure I understand how it's meant to work though. @cescoffier Could you help me to understand what would be the best now, please? Having updated images up and running on quay is definitely a higher priority for us than having multiarch. Should I remove the Mandrel multiarch from the current branch, do the update and iterate async later in the multi-arch branch? |
🙈 |
#203 needs to be integrated before this PR can. Also, once integrated this PR might need to be reworked. |
5e457b0
to
b9046fb
Compare
fixed... |
b9046fb
to
0efb439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks!
Can we have the rebuild triggered now? https://quay.io/repository/quarkus/ubi-quarkus-mandrel?tab=tags |
@Karm Probably but I would maybe prefer to rebuild both Mandrel and GraalVM images at the same time so that they're available (roughly) at the same time. GraalVM PRs look good but still need merging (I can't do that). |
No description provided.