Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandrel 21.3.3.0-Final and 22.2.0.0-Final July 2022 CPU #202

Merged

Conversation

Karm
Copy link
Member

@Karm Karm commented Jul 27, 2022

No description provided.

@Karm
Copy link
Member Author

Karm commented Jul 27, 2022

@zakkak @cescoffier https://github.com/graalvm/mandrel/releases/tag/mandrel-22.2.0.0-Final might have been in DRAFT state the second this CI was started, so if the download fails, restart the CI, please...

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Karm!

I think we should remove 22.0 mandrel modules at this point, in case you want to squeeze it in the same commit.

@Karm
Copy link
Member Author

Karm commented Jul 27, 2022

LGTM. Thanks @Karm!

I think we should remove 22.0 mandrel modules at this point, in case you want to squeeze it in the same commit.

How about we do a cleanup with the LTS? Like "when LTS comes, all previous in that major are dropped".

@zakkak
Copy link
Collaborator

zakkak commented Jul 27, 2022

How about we do a cleanup with the LTS? Like "when LTS comes, all previous in that major are dropped".

I recall having some issues with keeping that many images up to date, but I don't recall what the issue was. @cescoffier might have a better memory :)

@cescoffier
Copy link
Member

The deployment will fail, unfortunately. The whole deployment process is broken since multi-archs. Look at the multi-archs branch, which proposes a completely new approach to building the images.

@Karm
Copy link
Member Author

Karm commented Jul 27, 2022

The deployment will fail, unfortunately. The whole deployment process is broken since multi-archs. Look at the multi-archs branch, which proposes a completely new approach to building the images.

I've seen the multi-archs branch. Not sure I understand how it's meant to work though.

@cescoffier Could you help me to understand what would be the best now, please?

Having updated images up and running on quay is definitely a higher priority for us than having multiarch.

Should I remove the Mandrel multiarch from the current branch, do the update and iterate async later in the multi-arch branch?

@galderz
Copy link
Member

galderz commented Jul 28, 2022

... The whole deployment process is broken since multi-archs...

🙈

@galderz
Copy link
Member

galderz commented Jul 28, 2022

@cescoffier if my gift to you (21e25a3) is to problematic, why not revert it? As I already indicated in #196, 21e25a3 is only half of the job. You need the (hacked) code in the PR to be able to push things. So, I'd be very glad for my work to be reverted and unlock @Karm's and @gastaldi's PRs.

@galderz
Copy link
Member

galderz commented Jul 28, 2022

#203 needs to be integrated before this PR can. Also, once integrated this PR might need to be reworked.

@Karm Karm force-pushed the mandrel-22.2.0.0-Final-mandrel-21.3.3.0-Final branch from 5e457b0 to b9046fb Compare July 28, 2022 09:47
@Karm
Copy link
Member Author

Karm commented Jul 28, 2022

@galderz @zakkak I rebased, removed multiarch naming and also dropped old images.

@Karm
Copy link
Member Author

Karm commented Jul 28, 2022

O.K., that removal part was not a good move "Unable to find cekit module for version 21.2.0.2-Final-java11 - exiting"

fixed...

@Karm Karm force-pushed the mandrel-22.2.0.0-Final-mandrel-21.3.3.0-Final branch from b9046fb to 0efb439 Compare July 28, 2022 09:54
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

@gsmet gsmet merged commit ad21081 into quarkusio:main Jul 28, 2022
@Karm
Copy link
Member Author

Karm commented Jul 29, 2022

Can we have the rebuild triggered now?

https://quay.io/repository/quarkus/ubi-quarkus-mandrel?tab=tags

@galderz
Copy link
Member

galderz commented Jul 29, 2022

@Karm Probably but I would maybe prefer to rebuild both Mandrel and GraalVM images at the same time so that they're available (roughly) at the same time. GraalVM PRs look good but still need merging (I can't do that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants