checker for returnValue and contructor super call and auto add

[dufoli]

fix #67
fix #65

[dufoli]

Hello, code is ready with PR. I have just a doubt about impact of the classCreator close.

gizmo/src/main/java/io/quarkus/gizmo/BytecodeCreatorImpl.java

Line 987 in bda4d07

cc.close();

Else it is mostly store and load return handle so no impact because it call visitor ...

[dufoli]

I ma thinking to split isValid to isMissingReturnValue and isMissingSuper or this call in ctor.
To auto add call to object one by default:

            ctor.invokeSpecialMethod(
                    MethodDescriptor.ofConstructor("java.lang.Object"),
                    ctor.getThis());

wdyt ?

[Dufgui]

why not return null like https://github.com/llbit/ow2-asm/blob/master/src/org/objectweb/asm/MethodVisitor.java ?

[dufoli]

current code do not handle it :
AnnotationUtils.visitAnnotationValue do not check if first param is null.
But you are right asm standard said that it can return null if no visitor is needed.
Other solution is to return null and check it in

gizmo/src/main/java/io/quarkus/gizmo/AnnotationUtils.java

Line 9 in bda4d07

if (value.getClass().isArray()) {

[dufoli]

@gsmet @stuartwdouglas I provide 2 solutions for that. current code with dummy visitor or return null and handle it in AnnotationUtils. What do you prefer ?
Anyway, I need a full review before going further.

[dufoli]

@gsmet @stuartwdouglas @Sanne can you review it ?

[stuartwdouglas]

Why is this done as a visitor, rather than just checking that the bytecode is valid when it is generated?

[dufoli]

imagine you have a code with

public int myfunct(boolean foo, boolean bar) {
 if (foo) return 1
else if (bar) return 0;
else
throw new RuntimeException();
}

so you have 2 branchs of return to check indeed.
My first think was to check that last operation was a return and it failed because of that.
You have the exception case too...

[dufoli]

you can not check just the methodMody, you have to enter in operation to check them.
Or you mean that I check generated code instead of AST ?