Update expected Quarkus CLI text for command 'version' and disable failing CLI tests #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
force-pushed
the
feature/update-cli-help-text
branch
from
59e4092
to
51097fa
Compare
fedinskiy
approved these changes
Mar 29, 2023
|
The failure is obviously not related, but definitely something I need to look at :/ |
|
Opened upstream issue quarkusio/quarkus#32219 for CI failures. |
michalvavrik
force-pushed
the
feature/update-cli-help-text
branch
from
51097fa
to
0c4ac36
Compare
michalvavrik
changed the title
|
CI green, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Expected text for version help has changed due to quarkusio/quarkus@4af1c06#diff-28dd2b5fee9f9be1f967d404cde0b820f215e2fe6d9ead6579ecdcc8912efb60L194, now it shows
io.quarkus.cli.Versionheader. Couple of CLI tests are disabled due to the quarkusio/quarkus#32219.Please select the relevant options.
run testsphrase in comment)Checklist: