Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix framework compilation error after change of initConfiguration signature in Quarkus config builder change #1299

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 10, 2024

Summary

quarkusio/quarkus#43160 got merged which changes signature of the io.quarkus.deployment.configuration.BuildTimeConfigurationReader#initConfiguration which we use for detection of build-time configuration properties.

QE TS and this FW fail as they are run with newer version. However FW is also run with the latest released, so using reflection to support both Quarkus versions.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

I suppose it should be backported as everything will fail until 999-SNAPSHOT is released.

@fedinskiy
Copy link
Contributor

run tests

@michalvavrik
Copy link
Member Author

@fedinskiy there is one failure in native OpenShiftS2iQuickstartUsingDefaultsIT, it is unreliable test and I have already opened ticket for it in QQE last time you reviewed one of my PRs with OCP run.

@fedinskiy fedinskiy merged commit f831c7b into quarkus-qe:main Sep 11, 2024
9 of 10 checks passed
@michalvavrik michalvavrik deleted the feature/fix-fw-compilation-after-sr-config-change branch September 11, 2024 11:37
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants