-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reactive in the server extension #731
Add support for reactive in the server extension #731
Conversation
0741b08
to
98053a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @carlesarnal.
It seems like you're confusing the new dependencies for the classic and reactive implementations.
See https://quarkus.io/guides/rest-migration#dependencies.
RESTEasy Classic is still known as RESTEasy (quarkus-resteasy)
RESTEasy Reactive now is Quarkus REST (quarkus-rest).
I suggested changes to the pom.xml
files.
I also suggest using Maven Profiles to avoid test duplication. With that, you can have just one module and set a flag to run them with each profile (classic or reactive).
We do that in the client module.
That's all you need since all the tests are identical for both implementations.
In case we need specific tests for each implementation in the future, we can use the org.junit.jupiter.api.Tag
, like we did here.
Our CI already handles both profiles. See, for example, the job for the reactive profile.
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Co-authored-by: Helber Belmiro <helber.belmiro@gmail.com>
Tests are not exactly identical (the test class is). There are two different implementations in the Java projects one reactive and another non-reactive, and, if I merge them both into a single module, it will fail. I can make the tests use profiles to align with the rest of the project, but I don't think it's feasible to merge both modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlesarnal I see. I don't see a benefit in using profiles then.
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
This PR introduces support for generating reactive code using the server extension