Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft to support unexpected enum values #700

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

brice-laurencin
Copy link
Contributor

@brice-laurencin brice-laurencin commented Apr 12, 2024

resolves #692

This is a first draft, I would follow the guidelines if you thinks this feature is useful.
I still have an issue with numbered enum that I need to dig into, but I'd like to have a first feedback on this version.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

Copy link
Contributor

github-actions bot commented Apr 12, 2024

🎊 PR Preview e51dc0d has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-700.surge.sh

Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @brice-laurencin Thank you for your pull request!

Would be great to have a documentation for our users, to know how to use the new property, WYT?

@brice-laurencin
Copy link
Contributor Author

Definitely.
This is a first draft to know if I should push the effort further, if you (the maintainers of the extension) think this is valuable.

@ricardozanini
Copy link
Member

@brice-laurencin please go ahead!

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @brice-laurencin. Thank you.
I left a few minor comments.

@brice-laurencin
Copy link
Contributor Author

Good job @brice-laurencin. Thank you. I left a few minor comments.

Thanks a lot @hbelmiro, I'll have those fixed this week.

@ricardozanini ricardozanini merged commit fe50799 into quarkiverse:main Jun 14, 2024
11 checks passed
@hbelmiro
Copy link
Contributor

@all-contributors add @brice-laurencin for code.

Copy link
Contributor

@hbelmiro

I've put up a pull request to add @brice-laurencin! 🎉

@brice-laurencin
Copy link
Contributor Author

Thanks a lot @hbelmiro! 😊

@brice-laurencin
Copy link
Contributor Author

Hello @hbelmiro, it seems this code is gone from main with the new 3.0.0-SNAPSHOT version.

any reason for this?

(I just saw that as I'm trying to contribute a PR for #520 as I would very much need this)

@ricardozanini
Copy link
Member

@brice-laurencin have you looked at client module? We've moved things around to accommodate the new server module.

@brice-laurencin
Copy link
Contributor Author

I have, and it seems gone from the templates and the integration tests.
Searching for the config entries I added for this PR gives me nothing.

@ricardozanini
Copy link
Member

I'm unsure what happened then. @hbelmiro do you have any clues?

@brice-laurencin
Copy link
Contributor Author

Oh sorry. PEBKAC all the way here, I messed up between origin and upstream 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unexpected values in Enums
4 participants