-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft to support unexpected enum values #700
First draft to support unexpected enum values #700
Conversation
🎊 PR Preview e51dc0d has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-700.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @brice-laurencin Thank you for your pull request!
Would be great to have a documentation for our users, to know how to use the new property, WYT?
Definitely. |
@brice-laurencin please go ahead! |
11dc64f
to
e9eb03c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @brice-laurencin. Thank you.
I left a few minor comments.
client/deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/CodegenConfig.java
Outdated
Show resolved
Hide resolved
...in/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiGeneratorCodeGenBase.java
Outdated
Show resolved
Hide resolved
...ts/enum-unexpected/src/test/java/io/quarkiverse/openapi/generator/it/EnumUnexpectedTest.java
Outdated
Show resolved
Hide resolved
Thanks a lot @hbelmiro, I'll have those fixed this week. |
c364a8d
to
40bc3ee
Compare
@all-contributors add @brice-laurencin for code. |
I've put up a pull request to add @brice-laurencin! 🎉 |
Thanks a lot @hbelmiro! 😊 |
@brice-laurencin have you looked at |
I have, and it seems gone from the templates and the integration tests. |
I'm unsure what happened then. @hbelmiro do you have any clues? |
Oh sorry. PEBKAC all the way here, I messed up between |
resolves #692
This is a first draft, I would follow the guidelines if you thinks this feature is useful.
I still have an issue with numbered enum that I need to dig into, but I'd like to have a first feedback on this version.
Please make sure that your PR meets the following requirements:
[0.9.x] Subject