Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: error when input/openapi has cookies #681

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

ru4ert
Copy link
Contributor

@ru4ert ru4ert commented Mar 7, 2024

Expected Result:

    @GET
    @Path("/findByStatus")
    @Produces({"application/xml", "application/json"})
    @GeneratedMethod ("findPetsByStatus")
    public List<Pet> findPetsByStatus(
        @CookieParam("example-cookie") String exampleCookie, 
        @GeneratedParam("status") @QueryParam("status") String status
    ); 

Actual output:

    @GET
    @Path("/findByStatus")
    @Produces({"application/xml", "application/json"})
    @GeneratedMethod ("findPetsByStatus")
    public List<Pet> findPetsByStatus(
        , 
        @GeneratedParam("status") @QueryParam("status") String status
    );

Cannot address the origin of this error. Any thoughts?

Copy link
Contributor

github-actions bot commented Mar 7, 2024

🎊 PR Preview e91887f has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-681.surge.sh

@ricardozanini
Copy link
Member

@ru4ert I believe you should take a look at the api.qute template file and see how we are handling these parameters there.

@ru4ert
Copy link
Contributor Author

ru4ert commented Mar 11, 2024

@ricardozanini
Should i add tests/docu?

@ricardozanini
Copy link
Member

@ricardozanini Should i add tests/docu?

Sure thing! :)

@ricardozanini
Copy link
Member

@ru4ert let me know when this is ready for review!

@ru4ert
Copy link
Contributor Author

ru4ert commented Mar 12, 2024

@ru4ert i think you can review it. If you have CRs i will apply them later then

@hbelmiro hbelmiro merged commit bf99f33 into quarkiverse:main Mar 13, 2024
11 checks passed
@hbelmiro
Copy link
Contributor

@all-contributors add @ru4ert for code, tests, and docs.

Copy link
Contributor

@hbelmiro

I've put up a pull request to add @ru4ert! 🎉

@ru4ert
Copy link
Contributor Author

ru4ert commented Mar 13, 2024

@hbelmiro Thanks for the merge! Can you create a minor release?

@ricardozanini
Copy link
Member

ricardozanini commented Mar 13, 2024

@ru4ert I'm on it.

EDIT: @hbelmiro was faster :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants