Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rupert/additional function inputs #635

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Rupert/additional function inputs #635

merged 5 commits into from
Jan 29, 2024

Conversation

ru4ert
Copy link
Contributor

@ru4ert ru4ert commented Jan 23, 2024

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the discussion
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

#625 (comment)

@mcruzdev
Copy link
Member

mcruzdev commented Jan 23, 2024 •
edited
Loading

Hi @ru4ert, thank you! Looks good!

Can you add documentation to the new configuration?

mcruzdev
mcruzdev reviewed Jan 23, 2024
View reviewed changes
deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/CommonItemConfig.java
* Add custom/additional HTTP Headers or other args to every request
*/
@ConfigItem(name = "additional-request-args")
public Optional<String> additionalRequestArgs;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IHO, I think that the property could be additional-request-headers or something like it. WYT @hbelmiro?

Copy link
Contributor Author

@ru4ert ru4ert Jan 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcruzdev I think your not limited to just headers. See my Test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

🎊 PR Preview 94bb20b has been successfully built and deployed. See the documentation preview: https://quarkus-openapi-generator-preview-pr-635.surge.sh

@ru4ert ru4ert force-pushed the rupert/additional-function-inputs branch from f5fcbaf to e5f868f Compare January 23, 2024 15:28
@mcruzdev mcruzdev self-requested a review January 27, 2024 21:05
mcruzdev
mcruzdev reviewed Jan 27, 2024
View reviewed changes
Copy link
Member

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ru4ert thank you!
I think that you need to use the page docs/modules/ROOT/pages/includes/additional-request-args.adoc into the index.adoc.

@ru4ert ru4ert requested a review from mcruzdev January 28, 2024 06:04
@mcruzdev
Copy link
Member

LGTM! WYT @ricardozanini @hbelmiro?

Good job @ru4ert!

@mcruzdev
Copy link
Member

Fixes #643

@ricardozanini ricardozanini linked an issue Jan 29, 2024 that may be closed by this pull request
Add custom headers to method calls #643
Closed
@hbelmiro hbelmiro merged commit bfb4926 into quarkiverse:main Jan 29, 2024
11 checks passed
@hbelmiro
Copy link
Contributor

@all-contributors add @ru4ert for code and tests.

@allcontributors allcontributors bot mentioned this pull request Jan 29, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@hbelmiro

I've put up a pull request to add @ru4ert! 🎉

@ricardozanini ricardozanini mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardozanini ricardozanini ricardozanini approved these changes

@hbelmiro hbelmiro hbelmiro approved these changes

@mcruzdev mcruzdev mcruzdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add custom headers to method calls
4 participants
@ru4ert @mcruzdev @hbelmiro @ricardozanini