Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix upload-artifact@v4 issue #601

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Conversation

mcruzdev
Copy link
Member

@mcruzdev mcruzdev commented Dec 21, 2023

Many thanks for submitting your Pull Request ❤️!

Fixes #599.

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@ricardozanini
Copy link
Member

@mcruzdev I think the variable name is not getting from the matrix var. See: Artifact site-{{ matrix.java.version }}-{{ matrix.os }}.zip successfully finalized. Artifact ID 1129900601

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/preview.yml Outdated Show resolved Hide resolved
@ricardozanini
Copy link
Member

Another improvement, I think we can build only once the website in the preview pipeline. Doesn't make much sense publishing 4 artifacts in each matrix run.

@mcruzdev
Copy link
Member Author

Another improvement, I think we can build only once the website in the preview pipeline. Doesn't make much sense publishing 4 artifacts in each matrix run.

$ sign mistake, TY.

@ricardozanini
Copy link
Member

Another improvement, I think we can build only once the website in the preview pipeline. Doesn't make much sense publishing 4 artifacts in each matrix run.

$ sign mistake, TY.

Thank you for fixing it!!

@mcruzdev
Copy link
Member Author

@ricardozanini WYT about creating just one job to generate the site documentation and consume it in preview.

@ricardozanini
Copy link
Member

@ricardozanini WYT about creating just one job to generate the site documentation and consume it in preview.

Yes, exactly. We should remove the website upload from the matrix build. The other CI can just build skipping test since it's only interested in the website generation.

@mcruzdev
Copy link
Member Author

Done @ricardozanini :)

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Many thanks!!

@fjtirado fjtirado merged commit f108758 into quarkiverse:main Dec 22, 2023
11 checks passed
@hbelmiro
Copy link
Contributor

Awesome! Thank you very much @mcruzdev ❤️

@hbelmiro
Copy link
Contributor

@all-contributors add @mcruzdev for code and documentation.

Copy link
Contributor

@hbelmiro

I've put up a pull request to add @mcruzdev! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing
4 participants