-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix upload-artifact@v4 issue #601
Conversation
@mcruzdev I think the variable name is not getting from the |
Another improvement, I think we can build only once the website in the |
$ sign mistake, TY. |
Thank you for fixing it!! |
@ricardozanini WYT about creating just one job to generate the site documentation and consume it in preview. |
Yes, exactly. We should remove the website upload from the matrix build. The other CI can just build skipping test since it's only interested in the website generation. |
Done @ricardozanini :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Many thanks!!
Awesome! Thank you very much @mcruzdev ❤️ |
@all-contributors add @mcruzdev for code and documentation. |
I've put up a pull request to add @mcruzdev! 🎉 |
Many thanks for submitting your Pull Request ❤️!
Fixes #599.
Please make sure that your PR meets the following requirements:
[0.9.x] Subject
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2
to backport the original PR to thequarkus2
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.